Skip to content

fix: GHA frontend builds fail when frontends hasn't changed#31742

Merged
mistercrunch merged 2 commits into
masterfrom
fix_frontend_builds
Jan 8, 2025
Merged

fix: GHA frontend builds fail when frontends hasn't changed#31742
mistercrunch merged 2 commits into
masterfrom
fix_frontend_builds

Conversation

@mistercrunch
Copy link
Copy Markdown
Member

@mistercrunch mistercrunch commented Jan 8, 2025

I just merged #31490 and realized it fails when no frontend changes are found. It will run the first workflow and fail on subsequent.

This PR makes it such that the first workflow emits an output to tell the other workflows to skip if needed.

To test it, I had to remove the regex in scripts/change_detector.py that looks whether the specific GHA I'm altering here has been changed and it skipped as expected:

Screenshot 2025-01-07 at 5 15 52 PM

... and reenabled the rule after testing

I just merged #31490 and realize
it fails when no frontend changes are found. It will run the first
workflow and fail on subsequent.

This PR makes it such that the first workflow emits an output to tell
the other workflows to skip if needed.
@github-actions github-actions Bot added the github_actions Pull requests that update GitHub Actions code label Jan 8, 2025
Copy link
Copy Markdown

@korbit-ai korbit-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues... but I did find this frog.

           .--._.--.
          ( O     O )
          /   . .   \
         .`._______.'.
        /(           )\
      _/  \  \   /  /  \_
   .~   `  \  \ /  /  '   ~.
  {    -.   \  V  /   .-    }
_ _`.    \  |  |  |  /    .'_ _
>_       _} |  |  | {_       _<
 /. - ~ ,_-'  .^.  `-_, ~ - .\
         '-'|/   \|`-`

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings
Setting Value
Review Schedule Automatic excluding drafts
Max Issue Count 10
Automatic PR Descriptions
Issue Categories
Category Enabled
Naming
Database Operations
Documentation
Logging
Error Handling
Systems and Environment
Objects and Data Structures
Readability and Maintainability
Asynchronous Processing
Design Patterns
Third-Party Libraries
Performance
Security
Functionality

Feedback and Support

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

@mistercrunch mistercrunch merged commit d5a4815 into master Jan 8, 2025
@mistercrunch mistercrunch deleted the fix_frontend_builds branch January 8, 2025 01:33
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 5.0.0 First shipped in 5.0.0 labels Jul 29, 2025
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels github_actions Pull requests that update GitHub Actions code preset-io size/S 🚢 5.0.0 First shipped in 5.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants