[security] prevent XSS markup viz#3211
Merged
Merged
Conversation
|
Coverage remained the same at 69.349% when pulling 8bfc8251402cd722ae202e0844ba9c13b283af45 on mistercrunch:sandbox_markup into 299e9ce on apache:master. |
1 similar comment
|
Coverage remained the same at 69.349% when pulling 8bfc8251402cd722ae202e0844ba9c13b283af45 on mistercrunch:sandbox_markup into 299e9ce on apache:master. |
Member
Author
|
#3262 should unblock this effort |
mistercrunch
force-pushed
the
sandbox_markup
branch
from
8bfc825 to
26fcfa3
Compare
|
Coverage increased (+0.03%) to 69.335% when pulling 26fcfa3919c96a80d48ea11615b42a74cbe87460 on mistercrunch:sandbox_markup into 327c052 on apache:master. |
mistercrunch
changed the title
Member
Author
|
The only issue left is somewhere around our custom font "Roboto" not working in iframes. Can we helvetica? |
We protect the browser by sandboxing the user code inside an iframe
mistercrunch
force-pushed
the
sandbox_markup
branch
from
26fcfa3 to
1b3d135
Compare
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
* Prevent XSS in Markup viz We protect the browser by sandboxing the user code inside an iframe * Helvetica
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works but the CSS styling doesn't carry through. Would have to refactor the theme's CSS out of the javascript build and reference it in the iframe to make it work.