Skip to content

feat: security, user group support#32121

Merged
dpgaspar merged 22 commits intoapache:masterfrom
preset-io:feat/user-groups
Mar 4, 2025
Merged

feat: security, user group support#32121
dpgaspar merged 22 commits intoapache:masterfrom
preset-io:feat/user-groups

Conversation

@dpgaspar
Copy link
Copy Markdown
Member

@dpgaspar dpgaspar commented Feb 3, 2025

SUMMARY

This change completes phase 1 of SIP-152

Screenshot 2025-02-28 at 10 50 29

Group with a Gamma role and a data access role with datasource births
Screenshot 2025-02-28 at 11 11 29

A user gamma1 with Group1
Screenshot 2025-02-28 at 11 12 34

gamma1 user dashboard list
Screenshot 2025-02-28 at 11 13 28

gamma1 filtered datasets dropdown
Screenshot 2025-02-28 at 11 16 27

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@korbit-ai
Copy link
Copy Markdown

korbit-ai Bot commented Feb 3, 2025

Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment /korbit-review.

Your admin can change your review schedule in the Korbit Console

@pull-request-size pull-request-size Bot added size/L and removed size/M labels Feb 24, 2025
@github-actions github-actions Bot added the risk:db-migration PRs that require a DB migration label Feb 24, 2025
@pull-request-size pull-request-size Bot added size/M and removed size/L labels Feb 24, 2025
@github-actions github-actions Bot removed the risk:db-migration PRs that require a DB migration label Feb 24, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.46%. Comparing base (76d897e) to head (e2384ed).
Report is 1517 commits behind head on master.

Files with missing lines Patch % Lines
superset/views/utils.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #32121       +/-   ##
===========================================
+ Coverage   60.48%   83.46%   +22.97%     
===========================================
  Files        1931      546     -1385     
  Lines       76236    39106    -37130     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    32639    -13475     
+ Misses      28017     6467    -21550     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.53% <77.77%> (-0.64%) ⬇️
javascript ?
mysql 75.88% <88.88%> (?)
postgres 75.94% <88.88%> (?)
presto 53.05% <77.77%> (-0.76%) ⬇️
python 83.46% <88.88%> (+19.97%) ⬆️
sqlite 75.44% <88.88%> (?)
unit 61.12% <44.44%> (+3.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Copy Markdown
Contributor

@dpgaspar Processing your ephemeral environment request here. Action: up.

@github-actions
Copy link
Copy Markdown
Contributor

@dpgaspar Ephemeral environment spinning up at http://34.210.187.118:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.

@github-actions
Copy link
Copy Markdown
Contributor

@dpgaspar Processing your ephemeral environment request here. Action: up.

@github-actions
Copy link
Copy Markdown
Contributor

@dpgaspar Ephemeral environment spinning up at http://35.95.34.2:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.

@villebro
Copy link
Copy Markdown
Member

Exciting!

@github-actions
Copy link
Copy Markdown
Contributor

@dpgaspar Processing your ephemeral environment request here. Action: up.

@github-actions
Copy link
Copy Markdown
Contributor

@dpgaspar Ephemeral environment spinning up at http://34.221.39.197:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.

@dpgaspar dpgaspar marked this pull request as ready for review February 28, 2025 11:17
@dosubot dosubot Bot added authentication:access-control Rlated to access control authentication:fab Related to authentication with FAB labels Feb 28, 2025
Copy link
Copy Markdown

@korbit-ai korbit-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.
Category Issue Fix Detected
Functionality Incorrect Role ID Reference in Group Permission Filter ▹ view
Files scanned
File Path Reviewed
superset/security/guest_token.py
superset/views/utils.py
superset/security/manager.py

Explore our documentation to understand the languages and file types we support and the files we ignore.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Feedback and Support

Comment thread superset/security/manager.py
Copy link
Copy Markdown
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@dpgaspar dpgaspar merged commit 15cf066 into apache:master Mar 4, 2025
@dpgaspar dpgaspar deleted the feat/user-groups branch March 4, 2025 09:54
alexandrusoare pushed a commit to alexandrusoare/superset that referenced this pull request Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

authentication:access-control Rlated to access control authentication:fab Related to authentication with FAB size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants