feat: security, user group support#32121
Conversation
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #32121 +/- ##
===========================================
+ Coverage 60.48% 83.46% +22.97%
===========================================
Files 1931 546 -1385
Lines 76236 39106 -37130
Branches 8568 0 -8568
===========================================
- Hits 46114 32639 -13475
+ Misses 28017 6467 -21550
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@dpgaspar Ephemeral environment spinning up at http://34.210.187.118:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup. |
|
@dpgaspar Ephemeral environment spinning up at http://35.95.34.2:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup. |
|
Exciting! |
|
@dpgaspar Ephemeral environment spinning up at http://34.221.39.197:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup. |
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Fix Detected |
|---|---|---|
| Incorrect Role ID Reference in Group Permission Filter ▹ view | ✅ |
Files scanned
| File Path | Reviewed |
|---|---|
| superset/security/guest_token.py | ✅ |
| superset/views/utils.py | ✅ |
| superset/security/manager.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-reviewon this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-reviewcommand in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-descriptioncommand in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolvecommand in any comment on your PR.- Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Feedback and Support
(cherry picked from commit 15cf066)
SUMMARY
This change completes phase 1 of SIP-152
user_view_menu_namesGroup with a

Gammarole and a data access role with datasource birthsA user

gamma1with Group1gamma1user dashboard listgamma1filtered datasets dropdownBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION