Skip to content

fix(ui): bump AntD to 5.26.0 to fix Splitter drag menu issue#35782

Merged
EnxDev merged 20 commits into
masterfrom
exndev/fix/antd-splitter
Nov 6, 2025
Merged

fix(ui): bump AntD to 5.26.0 to fix Splitter drag menu issue#35782
EnxDev merged 20 commits into
masterfrom
exndev/fix/antd-splitter

Conversation

@EnxDev
Copy link
Copy Markdown
Contributor

@EnxDev EnxDev commented Oct 22, 2025

SUMMARY

The Splitter selector caused the menu to remain in a stuck state after dragging on SQL Lab

Upgrading AntD from 5.24.9 to 5.26.0 resolves this behavior

The Ant Design Table component internally uses a hidden row called MeasureRow to calculate column widths.
This row generates a <div class="ant-table-measure-cell-content">textContent</div> for each column, which results in duplicate elements compared to the visible table cells.

This PR also updates the tests to account for these duplicates by refining selectors, ensuring they target only the intended visible elements.

NB: With this version of AntD, when we introduce React 19, we'll need to include the @ant-design/v5-patch-for-react-19 patch.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  1. All tests should pass
  2. In SQL Lab, drag the divider up and down
  3. Try to type in the SQL text area

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@EnxDev EnxDev requested review from geido and msyavuz October 22, 2025 06:19
@EnxDev EnxDev added the change:frontend Requires changing the frontend label Oct 22, 2025
@bito-code-review
Copy link
Copy Markdown
Contributor

bito-code-review Bot commented Oct 22, 2025

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at evan@preset.io.

Copy link
Copy Markdown

@korbit-ai korbit-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@github-actions
Copy link
Copy Markdown
Contributor

⚠️ DEPRECATED WORKFLOW ⚠️

@EnxDev This workflow is deprecated! Please use the new Superset Showtime system instead:

Processing your ephemeral environment request here. Action: up. More information on how to use or configure ephemeral environments

@github-actions
Copy link
Copy Markdown
Contributor

@EnxDev Ephemeral environment spinning up at http://34.216.214.194:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup.

@EnxDev EnxDev force-pushed the exndev/fix/antd-splitter branch 2 times, most recently from 0391f91 to 4f9b130 Compare October 25, 2025 00:40
@EnxDev EnxDev force-pushed the exndev/fix/antd-splitter branch from 4f9b130 to 829fbbc Compare October 25, 2025 14:57
@github-actions github-actions Bot added api Related to the REST API doc Namespace | Anything related to documentation plugins labels Oct 25, 2025
@github-actions github-actions Bot removed api Related to the REST API doc Namespace | Anything related to documentation plugins labels Oct 25, 2025
@github-actions
Copy link
Copy Markdown
Contributor

🎪 Showtime deployed environment on GHA for f41eab6

Environment: http://44.248.63.5:8080 (admin/admin)
Lifetime: 48h auto-cleanup
Updates: New commits create fresh environments automatically

Copy link
Copy Markdown
Member

@msyavuz msyavuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this. Hopefully next upgrades will be easier. Have a small nit but i think this looks good

@EnxDev EnxDev requested a review from msyavuz November 4, 2025 17:24
Copy link
Copy Markdown
Member

@msyavuz msyavuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Checked the changelogs and tested the app with this. I couldn't find any visual issues with the bump

Copy link
Copy Markdown
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EnxDev EnxDev merged commit 84a1abd into master Nov 6, 2025
84 of 86 checks passed
@EnxDev EnxDev deleted the exndev/fix/antd-splitter branch November 6, 2025 06:43
sadpandajoe pushed a commit that referenced this pull request Dec 4, 2025
sadpandajoe pushed a commit that referenced this pull request Dec 4, 2025
sadpandajoe pushed a commit that referenced this pull request Dec 16, 2025
aminghadersohi pushed a commit to aminghadersohi/superset that referenced this pull request Jan 17, 2026
aminghadersohi pushed a commit to aminghadersohi/superset that referenced this pull request Jan 24, 2026
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants