fix(ui): bump AntD to 5.26.0 to fix Splitter drag menu issue#35782
Conversation
|
Bito Automatic Review Skipped - Files Excluded |
|
@EnxDev This workflow is deprecated! Please use the new Superset Showtime system instead:
Processing your ephemeral environment request here. Action: up. More information on how to use or configure ephemeral environments |
|
@EnxDev Ephemeral environment spinning up at http://34.216.214.194:8080. Credentials are 'admin'/'admin'. Please allow several minutes for bootstrapping and startup. |
0391f91 to
4f9b130
Compare
4f9b130 to
829fbbc
Compare
…ow added by AntD for measuring table columns
|
🎪 Showtime deployed environment on GHA for f41eab6 • Environment: http://44.248.63.5:8080 (admin/admin) |
msyavuz
left a comment
There was a problem hiding this comment.
Thanks for taking care of this. Hopefully next upgrades will be easier. Have a small nit but i think this looks good
msyavuz
left a comment
There was a problem hiding this comment.
LGTM! Checked the changelogs and tested the app with this. I couldn't find any visual issues with the bump
(cherry picked from commit 84a1abd)
(cherry picked from commit 84a1abd)
(cherry picked from commit 84a1abd)
SUMMARY
The Splitter selector caused the menu to remain in a stuck state after dragging on SQL Lab
Upgrading AntD from 5.24.9 to 5.26.0 resolves this behavior
The Ant Design Table component internally uses a hidden row called MeasureRow to calculate column widths.
This row generates a
<div class="ant-table-measure-cell-content">textContent</div>for each column, which results in duplicate elements compared to the visible table cells.This PR also updates the tests to account for these duplicates by refining selectors, ensuring they target only the intended visible elements.
NB: With this version of AntD, when we introduce React 19, we'll need to include the @ant-design/v5-patch-for-react-19 patch.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before splitter drag menu
https://github.com/user-attachments/assets/d53679a4-59d7-4005-96ae-44d30b9fe261
After splitter drag menu
https://github.com/user-attachments/assets/6b800540-bd11-41af-a08f-8ba8dff45438
Before popover
https://github.com/user-attachments/assets/c2a504cf-2703-4cc9-a4e7-37e7acfff2c0
After popover
https://github.com/user-attachments/assets/80a24ede-e683-4c25-a65f-713d72d1b67f
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION