fix(ace-editor-popover): main AntD popover closes when clicking autocomplete suggestions in Ace Editor#35986
Conversation
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Missing container validation for autocomplete popup ▹ view | |
|
Incomplete autocomplete trigger detection ▹ view | |
|
Global selector may affect multiple editors ▹ view |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/packages/superset-ui-core/src/components/AsyncAceEditor/index.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
EnxDev
changed the title
![bito-code-review[bot]](https://avatars.githubusercontent.com/in/1061978?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review Agent Run #caf867
Actionable Suggestions - 1
-
superset-frontend/packages/superset-ui-core/src/components/AsyncAceEditor/index.tsx - 1
- Prohibited `any` types in TypeScript code · Line 212-213
Review Details
-
Files reviewed - 1 · Commit Range:
46a89fc..46a89fc- superset-frontend/packages/superset-ui-core/src/components/AsyncAceEditor/index.tsx
-
Files skipped - 0
-
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful
Bito Usage Guide
Commands
Type the following command in the pull request comment and save the comment.
-
/review- Manually triggers a full AI review. -
/pause- Pauses automatic reviews on this pull request. -
/resume- Resumes automatic reviews. -
/resolve- Marks all Bito-posted review comments as resolved. -
/abort- Cancels all in-progress reviews.
Refer to the documentation for additional commands.
Configuration
This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.
Documentation & Help
AI Code Review powered by
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
|
Unsafe type assertions on nullable DOM queries ▹ view | |
|
Missing validation for Ace operation structure ▹ view | |
 |
Uncached DOM queries in command handler ▹ view | |
|
Inefficient command name checking ▹ view |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/packages/superset-ui-core/src/components/AsyncAceEditor/index.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
… during command execution
geido
added
the
🎪 ⚡ showtime-trigger-start
github-actions
Bot
added
🎪 a08d7dc 🚦 building
and removed
🎪 ⚡ showtime-trigger-start
|
🎪 Showtime deployed environment on GHA for 1c1e4ef • Environment: http://54.186.220.31:8080 (admin/admin) |
|
🎪 Showtime deployed environment on GHA for 32ff3a3 • Environment: http://52.37.154.47:8080 (admin/admin) |
4 participants
SUMMARY
This PR fixes an issue where clicking inside the Ace Editor’s autocomplete popover caused the main AntD popover to close unexpectedly.
SOLUTION
Moved the
.ace_autocomplete elementinside the parent container to prevent event propagation from closing the main popover.Hooked into Ace’s
afterExec eventto reposition the autocomplete when it appears.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
https://github.com/user-attachments/assets/3ee05122-d2ee-4caa-9ec7-cf6a9a4a7585
After
https://github.com/user-attachments/assets/1e4426cd-203e-4e17-b2f6-9453cf4c4321
TESTING INSTRUCTIONS
Navigate to charts
ADDITIONAL INFORMATION