fix(Tabs): prevent infinite rerenders with nested tabs by msyavuz · Pull Request #37018 · apache/superset

msyavuz · 2026-01-09T18:24:23Z

SUMMARY

#35265 introduced a bug where refreshing a dashboard with nested tabs would cause infinite rerenders. This pr fixes that bug by introducing a lazy option to dashboard refresh action that doesn't update the global refresh time.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

tab-refresh-before.mp4

After:

tab-refresh-after.mp4

TESTING INSTRUCTIONS

Create a dashboard with nested tabs.
Refresh it using Refresh dashboard button on three-dot menu.

This should not cause infinite rerenders.

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

netlify · 2026-01-09T18:27:36Z

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	`45bb64d`
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/696147da56df590008bfd387
😎 Deploy Preview	https://deploy-preview-37018--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2026-01-09T19:01:45Z

🎪 Showtime is building environment on GHA for 45bb64d

github-actions · 2026-01-09T19:20:57Z

🎪 Showtime deployed environment on GHA for 45bb64d

• Environment: http://18.236.111.15:8080 (admin/admin)
• Lifetime: 48h auto-cleanup
• Updates: New commits create fresh environments automatically

bito-code-review · 2026-01-09T19:32:49Z

Code Review Agent Run #998926

Actionable Suggestions - 0

Review Details

Files reviewed - 3 · Commit Range: d983c0d..45bb64d
- superset-frontend/src/dashboard/actions/dashboardState.js
- superset-frontend/src/dashboard/components/gridComponents/Tab/Tab.jsx
- superset-frontend/src/dashboard/components/gridComponents/Tab/Tab.test.tsx
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

codeant-ai-for-open-source · 2026-01-10T14:40:57Z

CodeAnt AI is reviewing your PR.

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

github-actions · 2026-01-10T15:01:27Z

🎪 Showtime deployed environment on GHA for 92e5cac

• Environment: http://34.209.227.96:8080 (admin/admin)
• Lifetime: 48h auto-cleanup
• Updates: New commits create fresh environments automatically

bito-code-review · 2026-01-10T15:43:04Z

Bito Automatic Review Skipped – PR Already Merged

Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.
No action is needed if you didn't intend to review it. To get a review, you can type /review in a comment and save it

(cherry picked from commit 0294c30)

- Add AutoRefreshContext mock hooks to Tab.test.tsx so tests can simulate isRefreshInFlight/isAutoRefreshing state independently. - Add three regression tests covering gaps in the existing infinite-loop fix (apache#37018): * dedup key resets correctly when a second dashboard refresh produces a new lastRefreshTime, allowing exactly one additional lazy refresh. * Tab does NOT dispatch a lazy refresh while a dashboard refresh is already in flight. * Tab does NOT dispatch a lazy refresh while an auto-refresh cycle is active. - Spread jest.requireActual for the dashboardState actions mock so the reducer keeps its action-type constants in tests. - Clear the CHART_MOUNT_DELAY setTimeout on unmount / dependency change in Tab.tsx to avoid stale dispatches.

Harden the lazy-refresh effect in Tab.tsx to prevent stale dispatches and stranded dedup keys when a chart lives inside nested tabs. 1. Return a cleanup from the useEffect that clears the CHART_MOUNT_DELAY setTimeout. A tab that unmounts (or re-renders with different deps) within the 100ms window no longer fires a stale lazy-refresh dispatch. 2. Move the handledRefreshRef dedup-key claim inside the setTimeout callback so the key is only claimed after the dispatch actually fires. If a guard (isAutoRefreshing / isRefreshInFlight) short- circuits the effect, the key is not stranded, and the subsequent effect run can still schedule the refresh. Adds four regression tests in Tab.test.tsx covering: - isRefreshInFlight and isAutoRefreshing short-circuit paths - setTimeout cleanup on unmount - Dedup key reschedule after a guarded short-circuit clears Related: apache#39439, apache#37018 Co-Authored-By: bot_apk <apk@cognition.ai>

msyavuz added 3 commits January 9, 2026 21:15

fix(Tabs): prevent infinite rerenders with nested tabs

d983c0d

chore: update test

21e8934

test: add regression tests

45bb64d

pull-request-size Bot added the size/L label Jan 9, 2026

msyavuz marked this pull request as ready for review January 9, 2026 18:28

github-actions Bot added the preset-io label Jan 9, 2026

dosubot Bot added the dashboard:tab Related to the usage of tabs in the Dashboard label Jan 9, 2026

sadpandajoe added the 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR label Jan 9, 2026

github-actions Bot added 🎪 45bb64d 🚦 building 🎪 ⌛ 48h Environment expires after 48 hours (default) and removed 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR labels Jan 9, 2026

github-actions Bot added 🎪 45bb64d 🚦 deploying and removed 🎪 45bb64d 🚦 building labels Jan 9, 2026

geido approved these changes Jan 9, 2026

View reviewed changes

fix: ci

92e5cac

github-actions Bot added the 🎪 92e5cac 🚦 building label Jan 10, 2026

github-actions Bot removed 🎪 🎯 92e5cac labels Jan 10, 2026

msyavuz merged commit 0294c30 into master Jan 10, 2026
69 checks passed

msyavuz deleted the msyavuz/fix/infinite-refresh-bug branch January 10, 2026 15:38

sadpandajoe pushed a commit that referenced this pull request Jan 12, 2026

fix(Tabs): prevent infinite rerenders with nested tabs (#37018)

f1405d3

(cherry picked from commit 0294c30)

sadpandajoe added the v6.0 Label added by the release manager to track PRs to be included in the 6.0 branch label Jan 12, 2026

sadpandajoe pushed a commit that referenced this pull request Jan 12, 2026

fix(Tabs): prevent infinite rerenders with nested tabs (#37018)

aa3b497

(cherry picked from commit 0294c30)

dosubot Bot mentioned this pull request Jan 13, 2026

Superset 6.0.0 - Refresh dashboard button crashes the Superset UI #37093

Closed

9 tasks

jesperct pushed a commit to jesperct/superset that referenced this pull request Jan 19, 2026

fix(Tabs): prevent infinite rerenders with nested tabs (apache#37018)

c7c44b7

sadpandajoe added the 🎪 🛑 showtime-trigger-stop label Jan 29, 2026

dosubot Bot mentioned this pull request Jan 30, 2026

[Bug]: Infinite rendering loop and NS_BINDING_ABORTED on Force Refresh in Dashboards with Nested Tabs (v6.0.0) #37584

Closed

3 tasks

sadpandajoe removed 🎪 🛑 showtime-trigger-stop labels Mar 19, 2026

sfirke pushed a commit to sfirke/superset that referenced this pull request Apr 13, 2026

fix(Tabs): prevent infinite rerenders with nested tabs (apache#37018)

a827abf

dosubot Bot mentioned this pull request Apr 17, 2026

Infinite chart reload loop inside nested tabs on force refresh (v6, not present on v3.1.0) #39439

Closed

3 tasks

hainenber linked an issue Apr 19, 2026 that may be closed by this pull request

Infinite chart reload loop inside nested tabs on force refresh (v6, not present on v3.1.0) #39439

Closed

3 tasks

devin-ai-integration Bot mentioned this pull request Apr 20, 2026

test(dashboard): harden nested-tab refresh regression coverage xhcarina/superset#8

Open

6 tasks

This was referenced Apr 20, 2026

fix(dashboard): cancel pending nested-tab refresh on unmount xhcarina/superset#10

Open

fix(dashboard): cancel pending nested-tab refresh on unmount xhcarina/superset#14

Merged

qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026

fix(Tabs): prevent infinite rerenders with nested tabs (apache#37018)

a23d23e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(Tabs): prevent infinite rerenders with nested tabs#37018

fix(Tabs): prevent infinite rerenders with nested tabs#37018
msyavuz merged 4 commits into
masterfrom
msyavuz/fix/infinite-refresh-bug

msyavuz commented Jan 9, 2026 •

edited

Loading

Uh oh!

netlify Bot commented Jan 9, 2026

Uh oh!

github-actions Bot commented Jan 9, 2026

Uh oh!

github-actions Bot commented Jan 9, 2026

Uh oh!

bito-code-review Bot commented Jan 9, 2026 •

edited

Loading

Code Review Agent Run #998926

Uh oh!

codeant-ai-for-open-source Bot commented Jan 10, 2026

Uh oh!

github-actions Bot commented Jan 10, 2026

Uh oh!

Uh oh!

bito-code-review Bot commented Jan 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

msyavuz commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Uh oh!

netlify Bot commented Jan 9, 2026

✅ Deploy Preview for superset-docs-preview ready!

Uh oh!

github-actions Bot commented Jan 9, 2026

Uh oh!

github-actions Bot commented Jan 9, 2026

Uh oh!

bito-code-review Bot commented Jan 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #998926

Uh oh!

codeant-ai-for-open-source Bot commented Jan 10, 2026

Thanks for using CodeAnt! 🎉

Uh oh!

github-actions Bot commented Jan 10, 2026

Uh oh!

Uh oh!

bito-code-review Bot commented Jan 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

msyavuz commented Jan 9, 2026 •

edited

Loading

bito-code-review Bot commented Jan 9, 2026 •

edited

Loading