fix(theme): migrate APP_NAME to brandAppName theme token with backward compatibility

[gabotorresruiz]

SUMMARY

Original PR: #37059

Fixes #34865 where APP_NAME configuration stopped working for browser window/tab titles after the Ant Design v5 theme migration in Superset 6.0.

Changes:

• Added brandAppName theme token for application name in window titles
• Implemented 3-tier fallback: brandAppName → APP_NAME config → "Superset"
• Updated frontend title cleanup to use theme token instead of hardcoded "Superset"
• Applied fallback to bootstrap payload so React components receive correct value

Backward compatibility: Existing APP_NAME configurations continue to work automatically via fallback mechanism.

TESTING INSTRUCTIONS

1. Set APP_NAME = "Custom App Name" in superset_config.py
2. Start Superset and navigate to login page
3. Verify browser tab shows "Custom App Name" instead of "Superset"
4. Navigate to a dashboard/chart, verify title changes to dashboard name
5. Navigate away, verify title returns to "Custom App Name"

Or test with new theme system:

THEME_DEFAULT = {
    "token": {
        "brandAppName": "My Custom Analytics",
    }
}

ADDITIONAL INFORMATION

• Has associated issue: APP_NAME is not display in apache superset 6.0 #34865
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #149d8d

Actionable Suggestions - 0

Review Details

• Files reviewed - 7 · Commit Range: c1500fa..f7b08da

  • superset-frontend/packages/superset-core/src/ui/theme/types.ts
  • superset-frontend/src/dashboard/containers/DashboardPage.tsx
  • superset-frontend/src/explore/components/ExploreViewContainer/index.jsx
  • superset/config.py
  • superset/templates/superset/spa.html
  • superset/views/base.py
  • tests/unit_tests/views/test_base_theme_helpers.py
• Files skipped - 1

  • UPDATING.md - Reason: Filter setting
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful
  • Eslint (Linter) - ✔︎ Successful
  • MyPy (Static Code Analysis) - ✔︎ Successful
  • Astral Ruff (Static Code Analysis) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[netlify]

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	f7b08da
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/697297744a330500080bffe0
😎 Deploy Preview	https://deploy-preview-37370--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[codeant-ai-for-open-source]

Suggestion: The code captures originalTitle inside an effect that runs after the slice-name effect, so originalTitle may already have been overwritten by the slice-name effect and won't restore the true pre-mount title on unmount. Capture the initial document title at mount using a stable hook (e.g., useMemo) and reference that in the cleanup to reliably restore the original browser title. [logic error]

Severity Level: Critical 🚨

- ❌ Browser title fails to revert after leaving Explore.
- ⚠️ Users see stale tab titles after navigating away.

Suggested change

	// Update document title when slice name changes
	useEffect(() => {
	if (props.sliceName) {
	document.title = props.sliceName;
	}
	}, [props.sliceName]);
	// Restore original title on unmount (run once)
	useEffect(() => {
	const originalTitle = document.title;
	const originalTitle = useMemo(() => document.title, []);
	// Update document title when slice name changes
	useEffect(() => {
	if (props.sliceName) {
	document.title = props.sliceName;
	}
	}, [props.sliceName]);
	// Restore original title on unmount (run once)
	useEffect(() => {

Steps of Reproduction ✅

1. Open a saved chart in Explore so ExploreViewContainer mounts. The component is defined
at superset-frontend/src/explore/components/ExploreViewContainer/index.jsx (function
ExploreViewContainer, lines ~273+).

2. On mount React runs the first effect at lines 294-299 (useEffect for props.sliceName).
If props.sliceName is truthy, that effect sets document.title = props.sliceName (lines
295-298).

3. Immediately after, React runs the next effect at lines 301-312 (the "Restore original
title" effect). That effect executes const originalTitle = document.title at line 303 —
but because the sliceName effect already ran, document.title now holds the slice name, not
the pre-mount title.

4. When the component later unmounts, the cleanup (lines 304-310) restores document.title
to originalTitle (which is the slice name), so the browser tab does not revert to the
pre-mount application title. This reproduces the wrong restored title behavior.

Prompt for AI Agent 🤖

This is a comment left during a code review.

**Path:** superset-frontend/src/explore/components/ExploreViewContainer/index.jsx
**Line:** 294:303
**Comment:**
	*Logic Error: The code captures `originalTitle` inside an effect that runs after the slice-name effect, so `originalTitle` may already have been overwritten by the slice-name effect and won't restore the true pre-mount title on unmount. Capture the initial document title at mount using a stable hook (e.g., useMemo) and reference that in the cleanup to reliably restore the original browser title.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.

[codeant-ai-for-open-source]

Suggestion: Backwards-compatibility/config-order issue: brandAppName is evaluated at module import time and will not reflect APP_NAME overrides applied later by a local superset_config.py; allow an environment-based override that can be set externally (and keep a fallback) so deployments that set an app name via env var get the correct value without relying on import order. [possible bug]

Severity Level: Critical 🚨

- ❌ Browser title shows wrong app name on login.
- ❌ Dashboard/tab titles show stale/default name.
- ⚠️ Breaks backward compatibility for APP_NAME overrides.

Suggested change

	"brandAppName": APP_NAME,
	"brandAppName": os.environ.get("SUPERSET_APP_NAME", APP_NAME or "Superset"),

Steps of Reproduction ✅

1. Inspect `superset/config.py` where THEME_DEFAULT is declared; the token
`"brandAppName"` is assigned at `superset/config.py:905-906` to the value of `APP_NAME` at
module import time.

2. Provision a local override by creating `superset_config.py` with `APP_NAME = "My Custom
App"` and ensure it is discoverable on PYTHONPATH. The project loads `superset_config`
later in the file (the import block that applies local overrides executes after
THEME_DEFAULT is defined).

3. Start Superset. The module-level `APP_NAME` is updated by the `superset_config` import,
but THEME_DEFAULT["token"]["brandAppName"] remains the earlier bound value because it was
set during module import at `superset/config.py:902-912`.

4. Observe the browser tab/window titles (login page, dashboards) still showing the
old/default name instead of the `APP_NAME` from `superset_config.py`. This reproduces the
import-order issue where the theme token was captured too early. The suggested change
makes the token read from an env override or fallback so deployments that set app name via
env or later config still surface correctly in the theme.

Prompt for AI Agent 🤖

This is a comment left during a code review.

**Path:** superset/config.py
**Line:** 906:906
**Comment:**
	*Possible Bug: Backwards-compatibility/config-order issue: `brandAppName` is evaluated at module import time and will not reflect `APP_NAME` overrides applied later by a local `superset_config.py`; allow an environment-based override that can be set externally (and keep a fallback) so deployments that set an app name via env var get the correct value without relying on import order.

Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.60%. Comparing base (87bbd54) to head (87ea4f4).
⚠️ Report is 2 commits behind head on master.

Files with missing lines	Patch %	Lines
superset/views/base.py	50.00%	4 Missing and 5 partials ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #37370       +/-   ##
===========================================
+ Coverage        0   66.60%   +66.60%     
===========================================
  Files           0      642      +642     
  Lines           0    48997    +48997     
  Branches        0     5491     +5491     
===========================================
+ Hits            0    32634    +32634     
- Misses          0    15069    +15069     
- Partials        0     1294     +1294     

Flag	Coverage Δ
hive	41.91% <50.00%> (?)
mysql	64.66% <50.00%> (?)
postgres	64.74% <50.00%> (?)
presto	41.93% <50.00%> (?)
python	66.57% <50.00%> (?)
sqlite	64.43% <50.00%> (?)
unit	100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sadpandajoe]

Shouldn't this be PR id and not issue id?

[sadpandajoe]

left a nitpick for UPDATING.md but not a merge blocker

[bito-code-review]

Bito Automatic Review Skipped – PR Already Merged

Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.
No action is needed if you didn't intend to review it. To get a review, you can type /review in a comment and save it