Skip to content

Allow generic before_request #3970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
timifasubaa wants to merge 2 commits into from
Closed

Allow generic before_request #3970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c14a4f0
add line in config
timifasubaa Dec 1, 2017
69d5e5e
make before_request generic
timifasubaa Dec 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions superset/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,21 @@ def index(self):

sm = appbuilder.sm

before_request_functions = conf.get('BEFORE_REQUEST_FUNCTIONS')


@app.before_request
def before_request():
for f in before_request_functions:
try:
f()
except Exception as e:
print(
'Exception {} in before_request function {}'
.format(e, f.func_name))
logging.exception(e)


results_backend = app.config.get('RESULTS_BACKEND')

# Registering sources
Expand Down
2 changes: 2 additions & 0 deletions superset/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,8 @@ class CeleryConfig(object):

CONFIG_PATH_ENV_VAR = 'SUPERSET_CONFIG_PATH'

# List of functions that are executed before every request. Order may matter.
BEFORE_REQUEST_FUNCTIONS = []

# smtp server configuration
EMAIL_NOTIFICATIONS = False # all the emails are sent using dryrun
Expand Down