Skip to content

Add PUBLIC_ROLE_LIKE_GAMMA config flag#473

Merged
mistercrunch merged 2 commits into
apache:masterfrom
asydorchuk:master
May 17, 2016
Merged

Add PUBLIC_ROLE_LIKE_GAMMA config flag#473
mistercrunch merged 2 commits into
apache:masterfrom
asydorchuk:master

Conversation

@asydorchuk
Copy link
Copy Markdown
Contributor

The flag was suggested as part of this pull request: #415. The idea behind the flag is to configure the 'Public' role with the same set of permission as the 'GAMMA' role. This simplifies configuration of dashboards visible to anonymous users, while explicit grant of 'datasource_access' is still required.

@landscape-bot
Copy link
Copy Markdown

Code Health
Repository health increased by 0.05% when pulling cd8b8f0 on asydorchuk:master into 5a870fe on airbnb:master.

1 similar comment
@landscape-bot
Copy link
Copy Markdown

Code Health
Repository health increased by 0.05% when pulling cd8b8f0 on asydorchuk:master into 5a870fe on airbnb:master.

@landscape-bot
Copy link
Copy Markdown

Code Health
Repository health decreased by 0.05% when pulling 0c9bb74 on asydorchuk:master into 5a870fe on airbnb:master.

1 similar comment
@landscape-bot
Copy link
Copy Markdown

Code Health
Repository health decreased by 0.05% when pulling 0c9bb74 on asydorchuk:master into 5a870fe on airbnb:master.

@mistercrunch
Copy link
Copy Markdown
Member

Thanks for the PR. Master was broken when you branched offd, do you mind rebasing?

@landscape-bot
Copy link
Copy Markdown

Code Health
Repository health decreased by 0.05% when pulling ffc53c5 on asydorchuk:master into 5c0e30e on airbnb:master.

@coveralls
Copy link
Copy Markdown

coveralls commented May 17, 2016

Coverage Status

Coverage increased (+0.04%) to 82.02% when pulling ffc53c5 on asydorchuk:master into 5c0e30e on airbnb:master.

@mistercrunch
Copy link
Copy Markdown
Member

img

@mistercrunch mistercrunch merged commit 8a406b1 into apache:master May 17, 2016
@asydorchuk
Copy link
Copy Markdown
Contributor Author

Lol, nice gif. Thanks for the merge!

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.9.1 First shipped in 0.9.1 labels Feb 19, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.9.1 First shipped in 0.9.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants