SQL Lab - A multi-tab SQL editor#514
Merged
Merged
Conversation
mistercrunch
force-pushed
the
carapal
branch
2 times, most recently
from
ee317ec to
a90482e
Compare
14 tasks
|
In which release we will have this feature. |
Member
Author
|
@naveenh1 we should have a working version of this within a few weeks |
mistercrunch
force-pushed
the
carapal
branch
5 times, most recently
from
29d2272 to
d0d28e3
Compare
Member
Author
|
@ascott I think this is ready for a first round of review |
Member
Author
|
@bkyryliuk the commit log you brought in looks pretty bad, rebase over merge! Ideally there should only have been your commits stacked on top of mine. |
Member
|
my fault. |
|
sorry @mistercrunch haven't had a chance to look at this yet, will take a look tonight. |
| } | ||
| return ( | ||
| <Alert bsStyle="info"> | ||
| No query history yet... |
There was a problem hiding this comment.
we should add a todo that this needs to be wrapper for translation.
Member
Author
There was a problem hiding this comment.
Let's just assume all strings exposed to users need to be wrapped somehow, otherwise there'll be todos everywhere...
* Sync queries using tmp_id. * Fix the unit tests * Bux fixes. Pass 2.
mistercrunch
force-pushed
the
carapal
branch
2 times, most recently
from
e618f85 to
368706a
Compare
mistercrunch
force-pushed
the
carapal
branch
2 times, most recently
from
624eee8 to
f861167
Compare
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
* Carapal react mockup This is really just a mock up written in React to try different components. It could become scaffolding to build a prototype, or not. * Merging in Alanna's theme tweaks for SQL lab * Tweak the display of the alert message in navbar * Sketching the middleware refresh for Queries * Adjustments * Implement timer sync. * CTAS * Refactor the queries to be stored as a dict. (apache#994) * Download csv endpoint. (apache#992) * CSV download engdpoint. * Use lower case booleans. * Replcate loop with the object lookup by key. * First changes for the sync * Address comments * Fix query deletions. Update only the queries from the store. * Sync queries using tmp_id. * simplify * Fix the tests in the carapal. (apache#1023) * Sync queries using tmp_id. * Fix the unit tests * Bux fixes. Pass 2. * Tweakin' & linting * Adding alpha label to the SQL LAb navbar entry * Fixing the python unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.