[WiP] Thumbnails!

[mistercrunch]

todo

• test emails
• split the caching configuration
• cli command to prime thumbnails
• put behind feature flag(s)
• tests
• test different drivers

[codecov-io]

Codecov Report

Merging #6601 into master will decrease coverage by 8.72%.
The diff coverage is 82.79%.

@@            Coverage Diff             @@
##           master    #6601      +/-   ##
==========================================
- Coverage   64.89%   56.16%   -8.73%     
==========================================
  Files         428      525      +97     
  Lines       20934    23219    +2285     
  Branches     2330     2772     +442     
==========================================
- Hits        13585    13042     -543     
- Misses       7225     9767    +2542     
- Partials      124      410     +286

Impacted Files	Coverage Δ
superset/config.py	93.46% <ø> (-0.33%)	⬇️
superset/sql_lab.py	76.75% <100%> (+0.38%)	⬆️
superset/viz.py	71.89% <100%> (+0.35%)	⬆️
superset/views/schedules.py	59.45% <100%> (+0.36%)	⬆️
superset/views/base.py	69.27% <100%> (+0.16%)	⬆️
superset/views/__init__.py	100% <100%> (ø)	⬆️
superset/views/thumbnails.py	42.85% <42.85%> (ø)
superset/models/core.py	83.72% <50%> (+0.16%)	⬆️
superset/utils/json.py	82% <82%> (ø)
superset/views/core.py	75.05% <83.33%> (+2.15%)	⬆️
... and 348 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5db20e3...fac70c0. Read the comment docs.

[mistercrunch]

@mahendra any chance you can test this in your environment?

[mahendra]

I will test this weekend :-)

On Wed, Jan 9, 2019 at 4:16 PM Maxime Beauchemin ***@***.***> wrote: @mahendra <https://github.com/mahendra> any chance you can test this in your environment? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#6601 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHFFEg-QUgR31uaMODrNfQy9S24xmRhks5vBoZWgaJpZM4ZyoC8> .

-- Mahendra http://twitter.com/mahendra gpg key: E31C89FD <https://pgp.mit.edu/pks/lookup?op=get&search=0x7BEC08A5E31C89FD>

[mahendra]

we may need this at 30. This is because the JS based rendering takes a while to finish.

[mistercrunch]

Oh I meant to check in while-type loop here..

[mistercrunch]

Actually I switch to checking 30 times each 2 seconds instead of a few times every 30 seconds...

[mahendra]

@mistercrunch I got this error while testing the feature. (not had time to debug yet).

[2019-01-14 09:05:07,665: ERROR/ForkPoolWorker-1] Task email_reports.send[7070358d-d91f-4b11-b23c-6cc9cd46a937] raised unexpected: InvalidCookieDomainException('Document is cookie-averse', None, None)
Traceback (most recent call last):
  File "/Users/mahendram/work/incubator-superset/.venv/lib/python3.6/site-packages/celery/app/trace.py", line 382, in trace_task
    R = retval = fun(*args, **kwargs)
  File "/Users/mahendram/work/incubator-superset/.venv/lib/python3.6/site-packages/celery/app/trace.py", line 641, in __protected_call__
    return self.run(*args, **kwargs)
  File "/Users/mahendram/work/incubator-superset/superset/tasks/schedules.py", line 252, in schedule_email_report
    deliver_dashboard(schedule)
  File "/Users/mahendram/work/incubator-superset/superset/tasks/schedules.py", line 118, in deliver_dashboard
    url, window, ['grid-container'], user, config.get('EMAIL_REPORTS_WEBDRIVER'))
  File "/Users/mahendram/work/incubator-superset/superset/utils/selenium.py", line 78, in get_png_from_url
    driver = create_webdriver(user, webdriver)
  File "/Users/mahendram/work/incubator-superset/superset/utils/selenium.py", line 72, in create_webdriver
    driver.add_cookie(info)
  File "/Users/mahendram/work/incubator-superset/.venv/lib/python3.6/site-packages/selenium/webdriver/remote/webdriver.py", line 894, in add_cookie
    self.execute(Command.ADD_COOKIE, {'cookie': cookie_dict})
  File "/Users/mahendram/work/incubator-superset/.venv/lib/python3.6/site-packages/selenium/webdriver/remote/webdriver.py", line 321, in execute
    self.error_handler.check_response(response)
  File "/Users/mahendram/work/incubator-superset/.venv/lib/python3.6/site-packages/selenium/webdriver/remote/errorhandler.py", line 242, in check_response
    raise exception_class(message, screen, stacktrace)
selenium.common.exceptions.InvalidCookieDomainException: Message: Document is cookie-averse

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.