auto-set 'Is Temporal' to true where column_name == '__time'#6857
Merged
Conversation
mistercrunch
force-pushed
the
auto_is_dttm
branch
from
03599f8 to
d851e56
Compare
Codecov Report
@@ Coverage Diff @@
## master #6857 +/- ##
==========================================
+ Coverage 64.76% 64.78% +0.01%
==========================================
Files 421 421
Lines 20384 20393 +9
Branches 2249 2249
==========================================
+ Hits 13202 13211 +9
Misses 7049 7049
Partials 133 133
Continue to review full report at Codecov.
|
john-bodley
reviewed
Feb 18, 2019
john-bodley
reviewed
Feb 21, 2019
Member
john-bodley
left a comment
john-bodley
left a comment
There was a problem hiding this comment.
@mistercrunch that could be a good idea. According to the Druid SQL docs __time seems to be the only implicit time column.
mistercrunch
force-pushed
the
auto_is_dttm
branch
from
d851e56 to
26dbc3a
Compare
Member
Author
|
@john-bodley I integrated your comments |
john-bodley
approved these changes
Mar 4, 2019
kristw
added
!deprecated-label:bug
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
…6857) * auto-set 'Is Temporal' to true where column_name == '__time' * Adress comments * lint * clarifying name and comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #6853