Skip to content

[date-filter] Adding minus infinity#6968

Merged
kristw merged 2 commits into
apache:masterfrom
john-bodley:john-bodley--date-filter-minus-infinity
Mar 4, 2019
Merged

[date-filter] Adding minus infinity#6968
kristw merged 2 commits into
apache:masterfrom
john-bodley:john-bodley--date-filter-minus-infinity

Conversation

@john-bodley
Copy link
Copy Markdown
Member

@john-bodley john-bodley commented Mar 2, 2019

This PR adds a minus sign in front of the for the from time to better reflect that the start is at the dawn of time, as opposed to the end of time.

screen shot 2019-03-01 at 5 39 47 pm

to: @betodealmeida @soboko @kristw

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 2, 2019

Codecov Report

Merging #6968 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6968   +/-   ##
=======================================
  Coverage   64.76%   64.76%           
=======================================
  Files         421      421           
  Lines       20386    20386           
  Branches     2249     2249           
=======================================
  Hits        13204    13204           
  Misses       7049     7049           
  Partials      133      133
Impacted Files Coverage Δ
.../explore/components/controls/DateFilterControl.jsx 38.23% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a8bc84...3a02a70. Read the comment docs.

@kristw kristw added the #refine label Mar 3, 2019
@kristw kristw merged commit aded70a into apache:master Mar 4, 2019
@kristw kristw added enhancement:request Enhancement request submitted by anyone from the community and removed #refine labels Mar 20, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 First shipped in 0.34.0 labels Feb 28, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
* [date-filter] Adding minus infinity

* Update DateFilterControl.jsx

eqeqeq
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels enhancement:request Enhancement request submitted by anyone from the community 🚢 0.34.0 First shipped in 0.34.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants