Skip to content

Hit cache when viewing results in explore view#6990

Merged
mistercrunch merged 1 commit into
apache:masterfrom
villebro:results_cache
Mar 9, 2019
Merged

Hit cache when viewing results in explore view#6990
mistercrunch merged 1 commit into
apache:masterfrom
villebro:results_cache

Conversation

@villebro
Copy link
Copy Markdown
Member

@villebro villebro commented Mar 7, 2019

Currently pressing View results in Explore view calls viz.get_df(), which forces retrieval of data from the source. By calling viz.get_df_payload(), we can first check if the result is already cached.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 7, 2019

Codecov Report

Merging #6990 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6990   +/-   ##
=======================================
  Coverage   64.35%   64.35%           
=======================================
  Files         422      422           
  Lines       20587    20587           
  Branches     2255     2255           
=======================================
  Hits        13249    13249           
  Misses       7205     7205           
  Partials      133      133
Impacted Files Coverage Δ
superset/views/core.py 74.94% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e619405...d2bbaa4. Read the comment docs.

@mistercrunch
Copy link
Copy Markdown
Member

LGTM

@mistercrunch mistercrunch merged commit 0535a11 into apache:master Mar 9, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 First shipped in 0.34.0 labels Feb 28, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 First shipped in 0.34.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants