[api/v1][query_obj] add default prequeries array#7039
Merged
williaster merged 2 commits intoMar 15, 2019
Conversation
conglei
approved these changes
Mar 15, 2019
Contributor
|
Thanks for fixing this! |
Codecov Report
@@ Coverage Diff @@
## master #7039 +/- ##
=======================================
Coverage 64.45% 64.45%
=======================================
Files 421 421
Lines 20524 20524
Branches 2245 2245
=======================================
Hits 13229 13229
Misses 7168 7168
Partials 127 127
Continue to review full report at Codecov.
|
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
* [api/v1][query_obj] add default prequeries array * [api/v1][query_obj] fix prequeries type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR only affects the embeddable charts
/api/v1/queryendpoint. I'm working on addingreact<ChartDataProvider />components in@superset-uiand when I use the new (non-legacy)WordCloudPlugintogether withSuperChart+ChartClientI get the following stack trace from Python in the Superset App:POST /api/v1/query/=>{"datasource":{"id":3,"type":"table"},"queries":[{"granularity":"ds","metrics":[{"label":"sum__num"}],"groupby":["name"]}]}This is because
prequeriesis not passed for this chart, and there is no default on the Python side. This PR adds a default and updates the type, I think it's an optionalListofDicts, setting the default to{}errored downstream as something was trying to append to it 😄 so maybe it was typed wrong?@xtinec @conglei @kristw