Skip to content

Add all database access permission to 'Alpha' role #7271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mistercrunch merged 2 commits into from
Apr 15, 2019
Merged

Add all database access permission to 'Alpha' role #7271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e6f831
Add all database access permission to 'Alpha' role
mistercrunch Apr 10, 2019
8d1fe67
Grant all database access to Alpha
mistercrunch Apr 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion superset/security.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ class SupersetSecurityManager(SecurityManager):
}

ADMIN_ONLY_PERMISSIONS = {
'all_database_access',
'can_sql_json', # TODO: move can_sql_json to sql_lab role
'can_override_role_permissions',
'can_sync_druid_source',
Expand All @@ -84,6 +83,7 @@ class SupersetSecurityManager(SecurityManager):

ALPHA_ONLY_PERMISSIONS = set([
'muldelete',
'all_database_access',
'all_datasource_access',
])

Expand Down
6 changes: 3 additions & 3 deletions tests/security_tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,6 @@ def test_is_admin_only(self):
self.assertTrue(security_manager.is_admin_only(
security_manager.find_permission_view_menu(
'can_approve', 'Superset')))
self.assertTrue(security_manager.is_admin_only(
security_manager.find_permission_view_menu(
'all_database_access', 'all_database_access')))

def test_is_alpha_only(self):
self.assertFalse(security_manager.is_alpha_only(
Expand All @@ -148,6 +145,9 @@ def test_is_alpha_only(self):
self.assertTrue(security_manager.is_alpha_only(
security_manager.find_permission_view_menu(
'can_delete', 'DruidMetricInlineView')))
self.assertTrue(security_manager.is_alpha_only(
security_manager.find_permission_view_menu(
'all_database_access', 'all_database_access')))

def test_is_gamma_pvm(self):
self.assertTrue(security_manager.is_gamma_pvm(
Expand Down