[security] New, deprecate merge_perm, FAB method is fixed#7355
Merged
Conversation
dpgaspar
changed the title
Codecov Report
@@ Coverage Diff @@
## master #7355 +/- ##
==========================================
+ Coverage 64.89% 65.18% +0.28%
==========================================
Files 428 433 +5
Lines 20937 21428 +491
Branches 2330 2360 +30
==========================================
+ Hits 13588 13968 +380
- Misses 7225 7340 +115
+ Partials 124 120 -4
Continue to review full report at Codecov.
|
dpgaspar
changed the title
mistercrunch
approved these changes
Apr 29, 2019
Member
mistercrunch
left a comment
mistercrunch
left a comment
There was a problem hiding this comment.
Will merge after the FAB 2.0 PR is merged
mistercrunch
requested changes
Apr 30, 2019
Member
mistercrunch
left a comment
mistercrunch
left a comment
There was a problem hiding this comment.
Minor comment, otherwise LGTM.
The SupersetSecurityManager API is fairly public given that in most settings people are expected to create their own security manager. Let's make sure upgrading is easy.
| full_names = {d.full_name for d in user_datasources} | ||
| return [d for d in datasource_names if d in full_names] | ||
|
|
||
| def merge_perm(self, permission_name, view_menu_name): |
Member
There was a problem hiding this comment.
For backwards compatibility, we should just call self.add_permission_view_menu here and maybe add a deprecation warning.
mistercrunch
approved these changes
May 21, 2019
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
* [security] New, deprecate merge_perm, FAB method is fixed * [style] Fix, flakes * [tests] Fix, change merge_perm to add_permission_view_menu * [security] Fix, maintain merge_perm for compatibility * [security] New, deprecation warning on merge_perm method * [style] Fix, flake8 C812
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CATEGORY
SUMMARY
Since FAB version 2.0.0 that safe guards made on merge_perms on Superset were included on FAB.
This makes it possible to simplify Superset's custom SecurityManager. And remove
merge_perms.Note: Only after PR #7323
ADDITIONAL INFORMATION
REVIEWERS