Reduce db queries in /queries/ endpoint

[graceguo-supercat]

CATEGORY

Choose one

• Bug Fix
• Enhancement (new features, refinement)
• Refactor
• Add tests
• Build / Development Environment
• Documentation

SUMMARY

In #4833, we tried to introduce a feature that setting old async query status to be timed_out, when the query status stuck at pending or running after 6 hours. This status update will help front-end (browser) not fetching very old query status. But i found that backend actually didn't commit transaction, so the whole query/update logic seems no use.

In #7429 I was trying to fix this issue by adding db commit. But I also found in front-end javascript, we have logic that don't poll query status after SQLLAB_ASYNC_TIME_LIMIT_SEC reached. I feel the additional query/update in backend every second, seems expensive and not necessary. So I propose to remove this query/update logic from every polling request.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

n/a

TEST PLAN

CI and watch query polling.

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Requires DB Migration.
• Confirm DB Migration upgrade and downgrade tested.
• Introduces new feature or API
• Removes existing feature or API

REVIEWERS

@john-bodley @timifasubaa @mistercrunch @michellethomas

[codecov-io]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.20%. Comparing base (265e117) to head (70c0868).
⚠️ Report is 15087 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7498      +/-   ##
==========================================
- Coverage   65.20%   65.20%   -0.01%     
==========================================
  Files         435      435              
  Lines       21486    21477       -9     
  Branches     2378     2378              
==========================================
- Hits        14011    14005       -6     
+ Misses       7355     7352       -3     
  Partials      120      120              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.