Skip to content

Alternative fix for #7559#7575

Merged
mistercrunch merged 2 commits into
apache:masterfrom
mistercrunch:7559_alternative
Jun 1, 2019
Merged

Alternative fix for #7559#7575
mistercrunch merged 2 commits into
apache:masterfrom
mistercrunch:7559_alternative

Conversation

@mistercrunch
Copy link
Copy Markdown
Member

See #7559 for more context

@mistercrunch mistercrunch mentioned this pull request May 22, 2019
12 tasks
@betodealmeida
Copy link
Copy Markdown
Member

I think this should prevent any weird race conditions, @mistercrunch. Looks good to merge, but some tests are now failing.

+1

betodealmeida added a commit to lyft/incubator-superset that referenced this pull request May 22, 2019
betodealmeida added a commit that referenced this pull request May 23, 2019
* Fix for polling queries

* Revert changes due to #7575
@john-bodley john-bodley added the !deprecated-label:bug Deprecated label - Use #bug instead label May 23, 2019
@mistercrunch mistercrunch force-pushed the 7559_alternative branch 4 times, most recently from 9458c7a to 50d395d Compare June 1, 2019 15:23
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jun 1, 2019

Codecov Report

Merging #7575 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7575      +/-   ##
==========================================
+ Coverage   65.59%   65.59%   +<.01%     
==========================================
  Files         435      435              
  Lines       21694    21695       +1     
  Branches     2387     2387              
==========================================
+ Hits        14230    14231       +1     
  Misses       7343     7343              
  Partials      121      121
Impacted Files Coverage Δ
superset/sql_lab.py 76.88% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 722043c...bc6aef4. Read the comment docs.

@mistercrunch mistercrunch merged commit 4b5931f into apache:master Jun 1, 2019
@mistercrunch mistercrunch deleted the 7559_alternative branch June 1, 2019 16:21
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.34.0 First shipped in 0.34.0 labels Feb 28, 2024
@sadpandajoe sadpandajoe added #bug Bug report and removed !deprecated-label:bug Deprecated label - Use #bug instead labels Mar 18, 2026
baiondatainc pushed a commit to baiondatainc/superset that referenced this pull request May 4, 2026
* Fix for polling queries

* Revert changes due to apache/superset#7575
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
* Fix for polling queries

* Revert changes due to apache#7575
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
* Alternative fix for apache#7559

Just an idea...

* logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels #bug Bug report size/XS 🚢 0.34.0 First shipped in 0.34.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants