Fixed Histogram visualization bug. #8077
Merged
Merged
Conversation
Member
|
@kuckjwi0928 LGTM, but please run black on the PR to fix the CI error. |
Contributor
Author
Fixed it! |
Contributor
|
It seems that it failed because of execution time limit. I guess it's ok to merge this PR. |
Member
|
I restarted CI, let's merge once it completes if all is ok. |
Codecov Report
@@ Coverage Diff @@
## master #8077 +/- ##
==========================================
+ Coverage 65.57% 65.89% +0.31%
==========================================
Files 469 485 +16
Lines 22495 22917 +422
Branches 2448 2537 +89
==========================================
+ Hits 14752 15102 +350
- Misses 7620 7683 +63
- Partials 123 132 +9
Continue to review full report at Codecov.
|
etr2460
pushed a commit
to etr2460/incubator-superset
that referenced
this pull request
Aug 30, 2019
This reverts commit 7ac1a29.
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Aug 30, 2019
etr2460
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
Aug 30, 2019
This reverts commit 7ac1a29.
graceguo-supercat
pushed a commit
that referenced
this pull request
Aug 30, 2019
Member
|
Note: while this was later reverted in master after |
villebro
pushed a commit
that referenced
this pull request
Sep 8, 2019
Contributor
Author
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* Fix HistogramViz bug. * Fix ci black error.
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
This reverts commit b0d06a8.
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
* Fix HistogramViz bug. * Fix ci black error.
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This reverts commit 1d08012.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CATEGORY
SUMMARY
Modified type mismatch bug in histogram visualization.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS
@mistercrunch