Skip to content

Fixed Histogram visualization bug. #8077

Merged
villebro merged 2 commits into
apache:masterfrom
kuckjwi0928:master
Aug 24, 2019
Merged

Fixed Histogram visualization bug. #8077
villebro merged 2 commits into
apache:masterfrom
kuckjwi0928:master

Conversation

@kuckjwi0928
Copy link
Copy Markdown
Contributor

@kuckjwi0928 kuckjwi0928 commented Aug 20, 2019

CATEGORY

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

Modified type mismatch bug in histogram visualization.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

  • Go to histogram chart.
  • Check if the histogram chart is functioning normally.

ADDITIONAL INFORMATION

  • Has associated issue: Fixes histogram must be str not list #8028
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@mistercrunch

@villebro
Copy link
Copy Markdown
Member

@kuckjwi0928 LGTM, but please run black on the PR to fix the CI error.

@kuckjwi0928
Copy link
Copy Markdown
Contributor Author

@kuckjwi0928 LGTM, but please run black on the PR to fix the CI error.

Fixed it!

@ali-behjati
Copy link
Copy Markdown
Contributor

It seems that it failed because of execution time limit. I guess it's ok to merge this PR.

@villebro
Copy link
Copy Markdown
Member

I restarted CI, let's merge once it completes if all is ok.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #8077 into master will increase coverage by 0.31%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8077      +/-   ##
==========================================
+ Coverage   65.57%   65.89%   +0.31%     
==========================================
  Files         469      485      +16     
  Lines       22495    22917     +422     
  Branches     2448     2537      +89     
==========================================
+ Hits        14752    15102     +350     
- Misses       7620     7683      +63     
- Partials      123      132       +9
Impacted Files Coverage Δ
superset/viz.py 71.27% <0%> (ø) ⬆️
superset/assets/src/components/AnchorLink.jsx 83.33% <0%> (-16.67%) ⬇️
.../src/explore/components/ControlPanelsContainer.jsx 68.35% <0%> (-11.65%) ⬇️
...ashboard/components/gridComponents/ChartHolder.jsx 74.07% <0%> (-10.78%) ⬇️
...et/assets/src/dashboard/reducers/dashboardState.js 73.46% <0%> (-9.87%) ⬇️
...s/src/dashboard/components/gridComponents/Tabs.jsx 61.11% <0%> (-5.05%) ⬇️
superset/assets/src/explore/controlUtils.js 94.8% <0%> (-2.21%) ⬇️
...sets/src/dashboard/components/DashboardBuilder.jsx 79.68% <0%> (-2.14%) ⬇️
...ts/src/dashboard/components/gridComponents/Tab.jsx 66.66% <0%> (-1.52%) ⬇️
.../assets/src/dashboard/components/DashboardGrid.jsx 59.64% <0%> (-1.47%) ⬇️
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 319c1df...7fc524c. Read the comment docs.

@villebro villebro merged commit 7ac1a29 into apache:master Aug 24, 2019
etr2460 pushed a commit to etr2460/incubator-superset that referenced this pull request Aug 30, 2019
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Aug 30, 2019
etr2460 pushed a commit to airbnb/superset-fork that referenced this pull request Aug 30, 2019
graceguo-supercat pushed a commit that referenced this pull request Aug 30, 2019
@villebro villebro added the v0.34 label Aug 31, 2019
@villebro
Copy link
Copy Markdown
Member

Note: while this was later reverted in master after superset-ui* was bumped to 0.12, this fix is needed in 0.34 which is still on 0.11.

villebro pushed a commit that referenced this pull request Sep 8, 2019
@kuckjwi0928
Copy link
Copy Markdown
Contributor Author

@villebro
I will soon open a PR that has solved this problem properly.

related issue : #8266

@mistercrunch mistercrunch added 🍒 0.34.1 Cherry-picked to 0.34.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.35.0 First shipped in 0.35.0 labels Feb 28, 2024
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* Fix HistogramViz bug.

* Fix ci black error.
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
* Fix HistogramViz bug.

* Fix ci black error.
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v0.34 🍒 0.34.1 Cherry-picked to 0.34.1 🚢 0.35.0 First shipped in 0.35.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants