Skip to content

feat: bump superset-ui dependencies to v0.12 and plugins to v0.11#8115

Merged
kristw merged 6 commits into
apache:masterfrom
kristw:kristw--bump-v12
Aug 27, 2019
Merged

feat: bump superset-ui dependencies to v0.12 and plugins to v0.11#8115
kristw merged 6 commits into
apache:masterfrom
kristw:kristw--bump-v12

Conversation

@kristw
Copy link
Copy Markdown
Contributor

@kristw kristw commented Aug 26, 2019

CATEGORY

Choose one

  • Enhancement (new features, refinement)
  • Refactor

SUMMARY

  • Upgrade @superset-ui packages to 0.12
    • Some prop names changed for clarity
    • @superset-ui/query is split from @superset-ui/chart
    • Support for control panel as part of plugin
    • New durationFormatter cc: @villebro
  • Upgrade @superset-ui-plugins packages to 0.11
    • to make all plugins compatible with @superset-ui@0.12
  • Make changes to filter_box, time_table and deck.gl plugins that reside in this main repo to conform to the new APIs. (See migration guide from this PR)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

TEST PLAN

  • Verify that all charts are working like before
  • Try setting table filter

REVIEWERS

@etr2460

Comment thread superset/assets/package.json Outdated
},
"homepage": "https://superset.apache.org/",
"dependencies": {
"@airbnb/lunar": "~2.23.0",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this used / referenced?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used by the plugin-chart-table. There was an issue with the newest version of lunar (2.24) so I have to pin this until it is resolved.

@villebro
Copy link
Copy Markdown
Member

Thanks @kristw , will implement durationFormatter once this is merged.

Copy link
Copy Markdown
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for finishing up this upgrade!

@kristw kristw merged commit 56566c2 into apache:master Aug 27, 2019
@kristw kristw deleted the kristw--bump-v12 branch August 27, 2019 20:42
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #8115 into master will decrease coverage by 7.75%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8115      +/-   ##
==========================================
- Coverage   73.61%   65.86%   -7.76%     
==========================================
  Files         114      485     +371     
  Lines       11972    22943   +10971     
  Branches        0     2541    +2541     
==========================================
+ Hits         8813    15111    +6298     
- Misses       3159     7698    +4539     
- Partials        0      134     +134
Impacted Files Coverage Δ
superset/assets/src/chart/Chart.jsx 11.11% <ø> (ø)
...et/assets/src/visualizations/presets/MainPreset.js 0% <ø> (ø)
...ets/src/visualizations/FilterBox/transformProps.js 0% <0%> (ø)
superset/assets/src/chart/ChartRenderer.jsx 7.35% <0%> (ø)
...assets/src/visualizations/deckgl/transformProps.js 0% <0%> (ø)
...ets/src/visualizations/TimeTable/transformProps.js 0% <0%> (ø)
superset/assets/src/components/Checkbox.jsx 100% <0%> (ø)
...ations/deckgl/layers/Polygon/PolygonChartPlugin.js 0% <0%> (ø)
.../assets/src/dashboard/reducers/dashboardFilters.js 88.23% <0%> (ø)
...ets/src/dashboard/components/dnd/DragDroppable.jsx 94.59% <0%> (ø)
... and 367 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2085e89...5abe936. Read the comment docs.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.35.0 First shipped in 0.35.0 labels Feb 28, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
…ache#8115)

* feat: bump superset-ui dependencies to v0.12 and plugins to v0.11

* fix: update transformProps

* fix: update hooks

* fix: pin lunar version

* fix: lint

* fix: revert table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 0.35.0 First shipped in 0.35.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants