[fix] Adding time grains to DualLine#8800
Merged
Merged
Conversation
michellethomas
approved these changes
Dec 10, 2019
Codecov Report
@@ Coverage Diff @@
## master #8800 +/- ##
==========================================
+ Coverage 65.75% 65.91% +0.15%
==========================================
Files 482 482
Lines 24157 24157
Branches 2770 2770
==========================================
+ Hits 15885 15922 +37
+ Misses 8094 8057 -37
Partials 178 178
Continue to review full report at Codecov.
|
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Dec 10, 2019
(cherry picked from commit 2fb95cc)
12 tasks
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Adds the missing time granularity controls to the DualLine visualization type. This is a regression introduced by #8674.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
CI.
ADDITIONAL INFORMATION
REVIEWERS
to: @etr2460 @michellethomas