[log] fix, log model view permissions#8993
Merged
Merged
Conversation
dpgaspar
changed the title
dpgaspar
changed the title
willbarrett
requested changes
Jan 22, 2020
| self.assertTrue( | ||
| security_manager._is_admin_only( | ||
| security_manager.find_permission_view_menu("can_delete", "DatabaseView") | ||
| log_permissions = ["can_list", "can_show", "can_add", "can_edit", "can_delete"] |
Member
There was a problem hiding this comment.
By default, I think we don't want logs to be editable. I'd remove can_add, can_edit, and can_delete for all users.
Member
Author
dpgaspar
changed the title
…table # Conflicts: # superset/views/database/api.py
dpgaspar
changed the title
dpgaspar
changed the title
willbarrett
approved these changes
Jan 23, 2020
dpgaspar
changed the title
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
Limit MVC access to admin role only and limit REST API permissions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Restrict LogModelView permissions
TEST PLAN
Tested that users don't have access to the View and Api through
LogRestApiADDITIONAL INFORMATION
REVIEWERS