[routes] Re-adding FAB API routes for SqlMetricInlineView and TableModelView#9035
Merged
john-bodley merged 1 commit intoJan 28, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9035 +/- ##
=======================================
Coverage 59.43% 59.43%
=======================================
Files 369 369
Lines 11743 11743
Branches 2884 2884
=======================================
Hits 6980 6980
Misses 4584 4584
Partials 179 179Continue to review full report at Codecov.
|
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Jan 28, 2020
…delView (apache#9035) (cherry picked from commit a267446)
12 tasks
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
This PR re-adds the FAB API endpoints to the
SqlMetricInlineViewandTableModelViewview classes as currently Airbnb is using these to sync metadata. Note these were removed in #8960.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
Tested locally and confirmed that the API endpoints were accessible.
ADDITIONAL INFORMATION
REVIEWERS
to: @etr2460 @graceguo-supercat @michellethomas @mistercrunch