SIP-32: Moving frontend code to the base of the repo#9098
Merged
Conversation
suddjian
changed the title
nytai
reviewed
Feb 7, 2020
suddjian
force-pushed
the
toplevel-frontend
branch
from
7a7f156 to
5238666
Compare
suddjian
force-pushed
the
toplevel-frontend
branch
from
5238666 to
889602c
Compare
mistercrunch
approved these changes
Feb 10, 2020
Member
|
|
12 tasks
6 tasks
mistercrunch
added
🏷️ bot
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
* move assets out, get webpack dev working * update docs to reference superset-frontend * draw the rest of the owl * fix docs * fix webpack script * rats * correct docs * fix tox dox
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CATEGORY
SUMMARY
Implements changes outlined in SIP-32.
Removes the need for a symlink from
superset/statictosuperset/assetsby moving "assets" to a new top-level/superset-frontenddirectory.Webpack now outputs into the
superset/static/assetsfolder, copying any necessary assets.Simplifies
MANIFEST.in. Excluding frontend source is no longer necessary since the source doesn't live in the backend directory.Removing two more symlinks between frontend assets and docs, instead copying built files to the
staticfolder. This was necessary because copying the built files breaks these symlinks, but it also cleans up the directory structure.TEST PLAN
Running
npm run build,npm run dev, andnpm run dev-serverall seem to work correctly.Building the tarball seems to work fine, but could use additional verification as I'm not sure what all the failure states there might be.
Docker build seems to work fine, but could use more verification here as well.
Whether CI still works remains to be seen, this PR will test that.
ADDITIONAL INFORMATION
REVIEWERS
@nytai @willbarrett @mistercrunch @craig-rueda @rusackas @dpgaspar @DiggidyDave @villebro