Skip to content

Treemap controls migration #9352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rusackas merged 2 commits into from
Mar 24, 2020
Merged

Treemap controls migration #9352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f9a4f4d
Treemap
rusackas Mar 23, 2020
d45b3ff
linting
rusackas Mar 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1229,7 +1229,6 @@ Note the `y_axis_format` is defined under various section for some charts.
| `timed_refresh_immune_slices` | _N/A_ | |
| `toggle_polygons` | _N/A_ | |
| `transpose_pivot` | _N/A_ | |
| `treemap_ratio` | _N/A_ | |
Copy link
Copy Markdown
Member Author

@rusackas rusackas Mar 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kristw I'm assuming these should get yanked when things are moved, but correct me if I'm wrong.

| `url` | _N/A_ | |
| `userid` | _N/A_ | |
| `viewport` | _N/A_ | |
Expand Down
14 changes: 13 additions & 1 deletion superset-frontend/src/explore/controlPanels/Treemap.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,19 @@ export default {
expanded: true,
controlSetRows: [
['color_scheme', 'label_colors'],
['treemap_ratio'],
[
{
name: 'treemap_ratio',
config: {
type: 'TextControl',
label: t('Ratio'),
renderTrigger: true,
isFloat: true,
default: 0.5 * (1 + Math.sqrt(5)), // d3 default, golden ratio
description: t('Target aspect ratio for treemap tiles.'),
},
},
],
['number_format'],
],
},
Expand Down
9 changes: 0 additions & 9 deletions superset-frontend/src/explore/controls.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1046,15 +1046,6 @@ export const controls = {
]),
},

treemap_ratio: {
type: 'TextControl',
label: t('Ratio'),
renderTrigger: true,
isFloat: true,
default: 0.5 * (1 + Math.sqrt(5)), // d3 default, golden ratio
description: t('Target aspect ratio for treemap tiles.'),
},

number_format: {
type: 'SelectControl',
freeForm: true,
Expand Down