Skip to content

fix: FilterBox Select should be Creatable#9940

Merged
etr2460 merged 2 commits into
apache:masterfrom
ktmud:bugfix-select
May 28, 2020
Merged

fix: FilterBox Select should be Creatable#9940
etr2460 merged 2 commits into
apache:masterfrom
ktmud:bugfix-select

Conversation

@ktmud
Copy link
Copy Markdown
Member

@ktmud ktmud commented May 28, 2020

SUMMARY

This fixes the bug where users are not able to create new options in FilterBox select. This was because of a typo while migrating react-select (#9628).

I also fixed a UX issue where keep typing backspaces in an empty select loses focus. react-select fires onChange event in this case, which causes excessive rerenders.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Should allow create new options:

image

TEST PLAN

Added a Cypress test

ADDITIONAL INFORMATION

Copy link
Copy Markdown
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the quick fix!

I think your pr title needs to start with fix instead of bugfix btw

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 28, 2020

Codecov Report

Merging #9940 into master will decrease coverage by 6.53%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9940      +/-   ##
==========================================
- Coverage   71.31%   64.77%   -6.54%     
==========================================
  Files         585      531      -54     
  Lines       30887    29473    -1414     
  Branches     3236     2862     -374     
==========================================
- Hits        22027    19092    -2935     
- Misses       8750    10206    +1456     
- Partials      110      175      +65     
Flag Coverage Δ
#cypress 53.94% <100.00%> (+0.10%) ⬆️
#javascript ?
#python 71.53% <ø> (ø)
Impacted Files Coverage Δ
...rontend/src/visualizations/FilterBox/FilterBox.jsx 72.95% <100.00%> (+0.45%) ⬆️
...uperset-frontend/src/dashboard/util/dnd-reorder.js 0.00% <0.00%> (-100.00%) ⬇️
...rset-frontend/src/dashboard/util/getEmptyLayout.js 0.00% <0.00%> (-100.00%) ⬇️
.../src/dashboard/util/getFilterScopeFromNodesTree.js 0.00% <0.00%> (-93.19%) ⬇️
.../src/dashboard/components/FilterIndicatorGroup.jsx 11.76% <0.00%> (-88.24%) ⬇️
...c/explore/components/controls/withVerification.jsx 9.09% <0.00%> (-87.88%) ⬇️
...uperset-frontend/src/utils/getClientErrorObject.ts 0.00% <0.00%> (-87.10%) ⬇️
...src/dashboard/components/gridComponents/Header.jsx 10.52% <0.00%> (-86.85%) ⬇️
...rc/dashboard/components/gridComponents/Divider.jsx 13.33% <0.00%> (-86.67%) ⬇️
...c/dashboard/components/gridComponents/Markdown.jsx 6.59% <0.00%> (-82.42%) ⬇️
... and 203 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b296a0f...84231b9. Read the comment docs.

@ktmud ktmud changed the title bugfix: FilterBox Select should be Creatable fix: FilterBox Select should be Creatable May 28, 2020
@etr2460 etr2460 merged commit 4fe6f4f into apache:master May 28, 2020
etr2460 pushed a commit to airbnb/superset-fork that referenced this pull request May 28, 2020
* bugfix: FilterBox Select should be Creatable

* Fix Cypress test
@ktmud ktmud deleted the bugfix-select branch May 28, 2020 21:55
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
* bugfix: FilterBox Select should be Creatable

* Fix Cypress test
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.37.0 First shipped in 0.37.0 labels Mar 12, 2024
qfcwell pushed a commit to qfcwell/superset that referenced this pull request May 12, 2026
* bugfix: FilterBox Select should be Creatable

* Fix Cypress test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 0.37.0 First shipped in 0.37.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants