fix: FilterBox Select should be Creatable#9940
Merged
Merged
Conversation
etr2460
approved these changes
May 28, 2020
Member
etr2460
left a comment
There was a problem hiding this comment.
lgtm, thanks for the quick fix!
I think your pr title needs to start with fix instead of bugfix btw
Codecov Report
@@ Coverage Diff @@
## master #9940 +/- ##
==========================================
- Coverage 71.31% 64.77% -6.54%
==========================================
Files 585 531 -54
Lines 30887 29473 -1414
Branches 3236 2862 -374
==========================================
- Hits 22027 19092 -2935
- Misses 8750 10206 +1456
- Partials 110 175 +65
Continue to review full report at Codecov.
|
etr2460
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
May 28, 2020
* bugfix: FilterBox Select should be Creatable * Fix Cypress test
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
* bugfix: FilterBox Select should be Creatable * Fix Cypress test
qfcwell
pushed a commit
to qfcwell/superset
that referenced
this pull request
May 12, 2026
* bugfix: FilterBox Select should be Creatable * Fix Cypress test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
This fixes the bug where users are not able to create new options in FilterBox select. This was because of a typo while migrating
react-select(#9628).I also fixed a UX issue where keep typing backspaces in an empty select loses focus.
react-selectfiresonChangeevent in this case, which causes excessive rerenders.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Should allow create new options:
TEST PLAN
Added a Cypress test
ADDITIONAL INFORMATION