This repository was archived by the owner on May 12, 2021. It is now read-only.
TAJO-2146: Fragment interface cleanup#1015
Closed
jihoonson wants to merge 13 commits intoapache:masterfrom
Closed
Conversation
Contributor
|
Could you rebase it? |
Contributor
Author
|
Not ready for review. |
Contributor
Author
|
I don't know why the changes in already committed patches are also shown.
|
Contributor
Author
|
Now, ready for review. |
| * @param <F> Fragment class | ||
| * @param <P> Protocol Buffer Message class corresponding to the Fragment class | ||
| */ | ||
| public interface FragmentSerdeHelper<F extends Fragment, P extends Message> { |
Member
There was a problem hiding this comment.
IMO, FragmentSerde seems to be a more proper name. As far as I know, Helper is mostly used for a utility class.
Member
|
+1 |
Contributor
Author
|
Thanks. I've changed the class name as you suggested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.