This repository was archived by the owner on May 12, 2021. It is now read-only.
TAJO-2129: Apply new type implementation to Schema and Catalog.#1016
Closed
hyunsik wants to merge 26 commits intoapache:masterfrom
Closed
TAJO-2129: Apply new type implementation to Schema and Catalog.#1016hyunsik wants to merge 26 commits intoapache:masterfrom
hyunsik wants to merge 26 commits intoapache:masterfrom
Conversation
…into TAJO-2129
* Move some util methods in CatalogUtil to IdentifierUtil. * Rename struct to record. * Fix some bugs related to QualifiedIdentifier and Identifier.
…into TAJO-2129
…into TAJO-2129
| this.mapType = dataType.mapType; | ||
| } | ||
|
|
||
| // map type |
Member
Author
There was a problem hiding this comment.
Thank you for good finding. I removed the comments because the code itself is very intuitive.
Contributor
|
@hyunsik, nice work! I really like some clean simplified implementations related field, schema, and identifier. I left some trivial comments. |
Member
Author
|
Sure, I jut added |
Member
Author
|
I reflected your comments. Thank you for the comments. |
Contributor
|
Thanks for quick update. |
Contributor
|
Would you close this pr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://issues.apache.org/jira/browse/TAJO-2129.