TAJO-1952: Implement PartitionFileFragment#846
TAJO-1952: Implement PartitionFileFragment#846blrunner wants to merge 0 commit intoapache:masterfrom
Conversation
There was a problem hiding this comment.
I'm going to give a suggestion. We need to keep each method for one purpose if possible. That approach would keep logic simpler.
|
Could you rebase it against the latest revision? I'd like to try the patch on my machine. |
|
Thank you for your review. I've just rebased it against the latest version. |
There was a problem hiding this comment.
In my opionion, partitionKeys would be more proper because the attribute includes concatenated partition keys.
|
Thank your for your review. I've just reflected your comments. |
|
I updated the patch as following:
For the reference, I've tried to maintain existing codes as far as possible. |
|
Updated the patch as following:
|
|
Added unit test cases for PartitionedTableRewriter |
There was a problem hiding this comment.
It can be simplified with lambda.
|
Thank you for your detailed review. I reflected your comments. |
|
I changed |
|
Evaluated patch testing before and after
The results were same as following:
|
|
The Travis CI Build seems like a fail by another reason. Here is the pre-commit report by lasted patch as follows. https://builds.apache.org/job/PreCommit-TAJO-Build/900//console |
|
Is there a problem that needs to be fixed? |
|
I updated this PR as following:
|
This patch contains following modifications: