This repository was archived by the owner on May 12, 2021. It is now read-only.
TAJO-1905: Insert clause to partitioned table fails on S3#959
Closed
blrunner wants to merge 19 commits intoapache:masterfrom
Closed
TAJO-1905: Insert clause to partitioned table fails on S3#959blrunner wants to merge 19 commits intoapache:masterfrom
blrunner wants to merge 19 commits intoapache:masterfrom
Conversation
…into TAJO-2063
…into TAJO-2063
…into TAJO-2063
…into TAJO-2063
…into TAJO-2063
…into TAJO-1905
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Tajo output committer works as following:
FileTablespace::commitTablerenames first successful task's temp directory to final destination.But above approach will occurs FileNotFoundException because of eventual consistency of S3. To resolve it, I implemented output committer for S3 and the committer works as following:
S3TableSpace::commitTablecopies first successful task's temp directory to S3.This PR depends on #952. CTAS statement and INSERT statement for partition table ran successfully with this PR. For the reference, I was inspired by Netflix integrating spark slide(http://www.slideshare.net/piaozhexiu/netflix-integrating-spark-at-petabyte-scale-53391704).
To resolve this issue basically, each task need to write output to final destination and we need to implement pluggable output committer. But this way looks like a long time work. I think that this PR may be an interim work for the pluggable output committer.