Skip to content

Conversation

@dingelish
Copy link
Contributor

Description

Code coverage report generation has been stopped for a while due to toolchain upgrade. This PR fixes the report generation command cmake -DCOV=ON and make cov

Please release a set of build image after the merge.

Fixes # (issue)

Type of change (select or add applied and delete the others)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • API change with a documentation update
  • Additional test coverage
  • Code cleanup or just sync with upstream third-party crates

How has this been tested?

Code coverage report has been generated successfully at https://gist.github.com/dingelish/186ecb02002bb273a47e0cbfd1196483

Checklist

  • Fork the repo and create your branch from master.
  • If you've added code that should be tested, add tests.
  • If you've changed APIs, update the documentation.
  • Ensure the tests pass (see CI results).
  • Make sure your code lints/format.

@dingelish dingelish requested a review from mssun February 2, 2022 23:25
@dingelish dingelish self-assigned this Feb 2, 2022
@dingelish
Copy link
Contributor Author

TVM build failed. Upstream fix is apache/tvm#10147

@dingelish
Copy link
Contributor Author

rebased on #606

@mssun mssun merged commit 42f29d8 into apache:yu-fix-cov Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants