-
Notifications
You must be signed in to change notification settings - Fork 113
Add environment GUI and new mechanism to scan source files in workflow #2481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93e4c91 to
43c84da
Compare
9c9d5d5 to
e9e8972
Compare
e9e8972 to
8b59285
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the GUI of environment and some fixes to previous dataset features. For the backend of environment, see #2434
After introducing the environment, the way of uploading data and scanning data using workflow is presented in this blog. For more specific information, there is a demo video.
Features
View the Environment information at the workspace

Add dataset to the current environment

Preview Data File in Dataset of environment

Scan Files that are in the datasets

Implementation Details
The changes on the ScanSourceOperatorDesc
Previously, the source file is located by its absolute path and scanned into the workflow. Now, since all the files are within the dataset and managed by JGit, its physical file may not be directly available. Therefore, couple of changes are made regarding the way that source operator scans the file.
A new member variable is added:
class
DatasetFileDesccontains the softlink to the file in the dataset, and has utilities to read the file as stream/tempraory file.datasetFileDescwill be initialized whensetContextis called:A new parameter is added in the constructor:
If
datasetFileDescis set non-null(i.e. user system is enabled), when creating the input stream reader, the stream will be created usingdatasetFileDesc.fileInputStream: