Skip to content

Conversation

@bobbai00
Copy link
Contributor

This PR fixes the issues brought by #2413 that all packages sources are npm instead of yarn.

How the fix is done

Since when packages are from yarn's source, the NzTreeModule is not working for unknown reasons. I re-wrote the file tree component using angular-tree-component.

@bobbai00 bobbai00 requested a review from aglinxinyuan March 25, 2024 17:35
@bobbai00 bobbai00 self-assigned this Mar 25, 2024
Copy link
Contributor

@aglinxinyuan aglinxinyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bobbai00 bobbai00 merged commit ec698f5 into master Mar 25, 2024
@bobbai00 bobbai00 deleted the jiadong-fix-filetree-compilation branch March 25, 2024 18:32
@Yicong-Huang Yicong-Huang added the dependencies Pull requests that update a dependency file label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants