Add AI-Assistant flag and features #2801
Closed
+725
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunyad
requested changes
Aug 22, 2024
Contributor
yunyad
left a comment
yunyad
left a comment
There was a problem hiding this comment.
Generally LGTM, please check the comments.
core/amber/src/main/scala/edu/uci/ics/amber/engine/common/AmberConfig.scala
Outdated
Show resolved
Hide resolved
core/amber/src/main/scala/edu/uci/ics/amber/engine/common/AmberConfig.scala
Outdated
Show resolved
Hide resolved
yunyad
reviewed
Aug 23, 2024
yunyad
reviewed
Aug 23, 2024
core/amber/src/main/scala/edu/uci/ics/amber/engine/common/AmberConfig.scala
Outdated
Show resolved
Hide resolved
yunyad
reviewed
Aug 23, 2024
yunyad
reviewed
Aug 24, 2024
core/amber/src/main/scala/edu/uci/ics/amber/engine/common/AmberConfig.scala
Outdated
Show resolved
Hide resolved
yunyad
requested changes
Aug 24, 2024
Contributor
yunyad
left a comment
yunyad
left a comment
There was a problem hiding this comment.
Need to have a further discussion.
IamtherealBrian
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a flag to allow the user to use the AI assistant (currently only OpenAI) and introduces some AI features that enhance the user experience of the Python UDF after integrating with the Pyright language server. You can refer to the PR for the Pyright language server here: #2797.
Key change:
Flag:
If the user chooses the 'none' flag, all AI features will be hidden and not available to the user. Otherwise, the AI features will be accessible in the Python UDF editor.
Add Type Annotation:
This action requires the user to select a single argument in their Python UDF code. A UI with a suggestion for the selected argument will pop up. The user can choose to accept or decline the suggestion from OpenAI. If they accept the suggestion, it will be added to their code; otherwise, the code will remain unchanged. The suggestion is provided by OpenAI. After the backend receives the response from OpenAI, it will be forwarded to the frontend via a RESTful API.
Example:
7879e394439dc30d2e09baaf36062bf1.mp4
Add All Type Annotation:
This action requires the user to select a code block in their Python UDF code. The action will automatically identify all arguments without type annotations and provide type annotation suggestions for each argument sequentially. The selected code block will be sent to the backend for Python Abstract Syntax Tree (AST) analysis to locate arguments without type annotations, and the result will be sent back to the frontend via a RESTful API. If the user selects a code block that has no arguments or where all the arguments already have type annotations, the code will remain unchanged.
Example:
add.all.type.annotation.mp4
Summary:
With these two AI features, users can easily add type annotations to their code. This will enable the Pyright language server to perform better at detecting semantic errors after the type annotations are added.