Fix bug of workflow editor having smaller size #2834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sixsage
changed the title
sixsage
added a commit
that referenced
this pull request
Sep 25, 2024
…2867) ## Purpose Address #2810 #2809 with a different solution from #2834 With the solution in #2834, it is hard to use the workspace-editor components elsewhere as it is based on vh/vw styling. ## Changes Revoke the styling changes made in #2834 (back to using 100% instead of vh/vw and remove overflow: hidden) Dispatch "resize" event when workflow editor is loaded to invoke all the relevant resize handlers. ## Demo Demo is the same as #2834 as they fix the same bug Before (before #2834)  After 
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
## Purpose Address #2810 #2809 There was a bug with the current workflow editor workspace where after page reload, the html element with id="workflow-editor" had an incorrect size. This caused issues such as operators not being visible on the lower part of the page and the minimap window changing size. ## Changes Dispatch "resize" event when workflow editor is loaded to invoke all the relevant resize handlers. ## Demo Before (on texera.ics.uci.edu)  After 
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
…2867) ## Purpose Address #2810 #2809 with a different solution from #2834 With the solution in #2834, it is hard to use the workspace-editor components elsewhere as it is based on vh/vw styling. ## Changes Revoke the styling changes made in #2834 (back to using 100% instead of vh/vw and remove overflow: hidden) Dispatch "resize" event when workflow editor is loaded to invoke all the relevant resize handlers. ## Demo Demo is the same as #2834 as they fix the same bug Before (before #2834)  After 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Address #2810 #2809
There was a bug with the current workflow editor workspace where after page reload, the html element with id="workflow-editor" had an incorrect size. This caused issues such as operators not being visible on the lower part of the page and the minimap window changing size.
Changes
Change 100% to 100vw and 100vh for workflow-editor and workflow-editor-wrapper
Disable scroll through overflow: hidden in styles.css
Demo
Before (on texera.ics.uci.edu)
After