Add publish buttons to the dataset and workflow #2835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not modified them.
aglinxinyuan
approved these changes
Sep 25, 2024
Contributor
aglinxinyuan
left a comment
aglinxinyuan
left a comment
There was a problem hiding this comment.
LGTM! Please also mention 15.sql in your PR description.
Contributor
|
@aglinxinyuan please remember to add ddl-change label for PRs that changes the sql. |
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
**Purpose:** The current hub site does not distinguish between private and public workflows. This pr aims to introduce this concept and add methods for hub users to publish workflows from texera hub site. **Description:** 1. Added a toggle button to the workflow list item to help switching between public and private workflow 2. Changed the database schema to add is_public boolean attribute to the workflow table (Added 15.sql for database updates). 3. Implemented access checks so that only users with read or write access can change a workflow to publish Partially fixes #2741 (still need to add a clone button in the detail page). **Demo:** old share access button:  new share access button:  old workspace top bar:  share access button in workspace:  share access button in workspace after click:  --------- Co-authored-by: Xinyuan Lin <xinyual3@uci.edu> Co-authored-by: linxinyuan <linxinyuan@gmail.com> Co-authored-by: YS0meone <timyuan1016@gmail.com> Co-authored-by: sixsage <sixsage02@gmail.com> Co-authored-by: mengw15 <125719918+mengw15@users.noreply.github.com> Co-authored-by: Minchong(Brian) Wu <143851082+IamtherealBrian@users.noreply.github.com> Co-authored-by: Yicong Huang <17627829+Yicong-Huang@users.noreply.github.com> Co-authored-by: Yicong Huang <yicong.huang@observeinc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
The current hub site does not distinguish between private and public workflows. This pr aims to introduce this concept and add methods for hub users to publish workflows from texera hub site.
Description:
Partially fixes #2741 (still need to add a clone button in the detail page).
Demo:
old share access button:
new share access button:
old workspace top bar:
share access button in workspace:
share access button in workspace after click:
