Refactor Hub Workflow Search Results and Permission-Based Redirection #2838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not modified them.
sixsage
added
feature
refactor
core/gui/src/app/hub/component/workflow/search/hub-workflow-search.component.scss
Outdated
Show resolved
Hide resolved
core/gui/src/app/hub/component/workflow/search/hub-workflow-search.component.scss
Outdated
Show resolved
Hide resolved
aglinxinyuan
approved these changes
Sep 25, 2024
Contributor
aglinxinyuan
left a comment
aglinxinyuan
left a comment
There was a problem hiding this comment.
LGTM! Left some comments.
core/gui/src/app/dashboard/component/user/search-bar/search-bar.component.ts
Outdated
Show resolved
Hide resolved
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
…#2838) **Propose:** Modify the search results on the Hub Workflow page to use the SearchResultComponent from the general search, and implement different redirection behavior based on the user's login status and access permissions. **Change:** 1. Replaced the search results on the Hub Workflow page with the SearchResult Component used in the general search. 2. Handled different redirection scenarios: a) For users who are not logged in: Clicking on any workflow will redirect to the Workflow Detail page. b) For logged-in users: If the user clicks on a workflow they have access to, they will be redirected to the Workspace. If the user clicks on a workflow they don't have access to, they will be redirected to the Workflow Detail page. **Demo:** old hub-workflow interface:  new hub-workflow interface:  redirect demo: https://github.com/user-attachments/assets/21b70275-9f6b-4a71-b977-b39a58bd6a11 --------- Co-authored-by: Xinyuan Lin <xinyual3@uci.edu> Co-authored-by: linxinyuan <linxinyuan@gmail.com> Co-authored-by: YS0meone <timyuan1016@gmail.com> Co-authored-by: sixsage <sixsage02@gmail.com> Co-authored-by: mengw15 <125719918+mengw15@users.noreply.github.com> Co-authored-by: Minchong(Brian) Wu <143851082+IamtherealBrian@users.noreply.github.com> Co-authored-by: Yicong Huang <17627829+Yicong-Huang@users.noreply.github.com> Co-authored-by: Yicong Huang <yicong.huang@observeinc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propose:
Modify the search results on the Hub Workflow page to use the SearchResultComponent from the general search, and implement different redirection behavior based on the user's login status and access permissions.
Change:
a) For users who are not logged in: Clicking on any workflow will redirect to the Workflow Detail page.
b) For logged-in users: If the user clicks on a workflow they have access to, they will be redirected to the Workspace. If the user clicks on a workflow they don't have access to, they will be redirected to the Workflow Detail page.
Demo:
old hub-workflow interface:
new hub-workflow interface:
redirect demo:
https://github.com/user-attachments/assets/21b70275-9f6b-4a71-b977-b39a58bd6a11