-
Notifications
You must be signed in to change notification settings - Fork 113
Receive pattern_shape variable from user #2849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kunwp1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bar chart implementation looks great! After reviewing the Plotly documentation, I noticed that the pattern_shape feature is also supported in other visualization types. It would be a valuable enhancement to extend pattern_shape support to additional visualization operators, such as histograms, area charts, pie charts, sunburst charts, funnel area charts, icicle charts, and treemap charts.
Additionally, could you please include a detailed description in the PR? Specifically, it would be helpful to explain what the pattern_shape variable is and how it enhances the visualizations.
Thank you for the great work!
I added
The following ones accept a dictionary of patterns as input instead of column so need different configuration:
Other ones including scatter plot do not support texture. |
kunwp1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good! Feel free to merge the PR once you've formatted the files.
 One of the shared input parameters for many charts is `pattern_shape` which indicates the texture of the graph based on an attribute. Its another input variable for bar chart that adds texture. We added this attribute to 4 charts: - Bar chart - Filled Area - Gantt chart - Histogram
One of the shared input parameters for many charts is
pattern_shapewhich indicates the texture of the graph based on an attribute. Its another input variable for bar chart that adds texture.We added this attribute to 4 charts: