Skip to content

Conversation

@aicam
Copy link
Contributor

@aicam aicam commented Sep 19, 2024

WhatsApp Image 2024-09-19 at 4 44 13 PM

One of the shared input parameters for many charts is pattern_shape which indicates the texture of the graph based on an attribute. Its another input variable for bar chart that adds texture.
We added this attribute to 4 charts:

  • Bar chart
  • Filled Area
  • Gantt chart
  • Histogram

@aicam aicam requested a review from kunwp1 September 19, 2024 23:49
@aicam aicam self-assigned this Sep 19, 2024
Copy link
Contributor

@kunwp1 kunwp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bar chart implementation looks great! After reviewing the Plotly documentation, I noticed that the pattern_shape feature is also supported in other visualization types. It would be a valuable enhancement to extend pattern_shape support to additional visualization operators, such as histograms, area charts, pie charts, sunburst charts, funnel area charts, icicle charts, and treemap charts.

Additionally, could you please include a detailed description in the PR? Specifically, it would be helpful to explain what the pattern_shape variable is and how it enhances the visualizations.

Thank you for the great work!

@aicam
Copy link
Contributor Author

aicam commented Sep 20, 2024

The bar chart implementation looks great! After reviewing the Plotly documentation, I noticed that the pattern_shape feature is also supported in other visualization types. It would be a valuable enhancement to extend pattern_shape support to additional visualization operators, such as histograms, area charts, pie charts, sunburst charts, funnel area charts, icicle charts, and treemap charts.

Additionally, could you please include a detailed description in the PR? Specifically, it would be helpful to explain what the pattern_shape variable is and how it enhances the visualizations.

Thank you for the great work!

I added pattern_shape variable to the following components:

  • Bar chart
  • Filled Area
  • Gantt chart
  • Histogram

The following ones accept a dictionary of patterns as input instead of column so need different configuration:

  • Sunburst
  • Pie chart
  • Treemap
  • Icicle

Other ones including scatter plot do not support texture.

Copy link
Contributor

@kunwp1 kunwp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! Feel free to merge the PR once you've formatted the files.

@aicam aicam merged commit b125058 into master Sep 21, 2024
@aicam aicam deleted the feat-pattern-var branch September 21, 2024 05:35
PurelyBlank pushed a commit that referenced this pull request Dec 4, 2024
![WhatsApp Image 2024-09-19 at 4 44 13
PM](https://github.com/user-attachments/assets/4b53197e-8593-4471-abfa-728e44e38916)

One of the shared input parameters for many charts is `pattern_shape`
which indicates the texture of the graph based on an attribute. Its
another input variable for bar chart that adds texture.
We added this attribute to 4 charts:
- Bar chart
- Filled Area
- Gantt chart
- Histogram
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants