Upgrade the ng build command in deploy-daemon.sh
#2850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the `ng build` command in `deploy-daemon.sh`. Before the change, the command is: `ng build --prod --deploy-url=/ --base-href=/` However, `--prod` is deprecated according to https://github.com/angular/angular-cli/blob/main/CHANGELOG.md#breaking-changes-2 So I updated it to make it align with current angular: `ng build --configuration production --deploy-url=/ --base-href=/`
bobbai00
changed the title
ng build command in deploy-daemon.shng build command in deploy-daemon.sh
aglinxinyuan
approved these changes
Sep 20, 2024
Contributor
|
Hi @bobbai00 can you add in the description which angular version is deprecating this argument, and which one we are moving to? The link you send indicates it is version 18.0.0, but we are using angular 16? |
Contributor
Author
sure, I added it. |
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
This PR updates the `ng build` command in `deploy-daemon.sh`. Before the change, the command is: `ng build --prod --deploy-url=/ --base-href=/` However, `--prod` is deprecated in angular 14 according to https://github.com/angular/angular-cli/blob/main/CHANGELOG.md#breaking-changes-2 <img width="1072" alt="Screenshot 2024-09-19 at 10 02 56 PM" src="https://github.com/user-attachments/assets/03e5052e-d29a-4aeb-9d0c-71239795baef"> And our angular version is angular 16. So I updated it to make it align with current angular: `ng build --configuration production --deploy-url=/ --base-href=/`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
ng buildcommand indeploy-daemon.sh.Before the change, the command is:
ng build --prod --deploy-url=/ --base-href=/However,
--prodis deprecated in angular 14 according to https://github.com/angular/angular-cli/blob/main/CHANGELOG.md#breaking-changes-2And our angular version is angular 16.
So I updated it to make it align with current angular:
ng build --configuration production --deploy-url=/ --base-href=/