Move Tuple, State, and WorkflowRuntimeStatistics into Amber package #2913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yicong-Huang
changed the title
shengquan-ni
reviewed
Oct 9, 2024
core/amber/src/main/scala/edu/uci/ics/texera/workflow/common/workflow/WorkflowSettings.scala
Show resolved
Hide resolved
shengquan-ni
approved these changes
Oct 9, 2024
Contributor
shengquan-ni
left a comment
shengquan-ni
left a comment
There was a problem hiding this comment.
Left a minor comment.
Yicong-Huang
changed the title
# Conflicts: # core/amber/src/main/scala/edu/uci/ics/texera/web/resource/dashboard/user/dataset/DatasetResource.scala
Yicong-Huang
added a commit
that referenced
this pull request
Oct 23, 2024
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
…2913) As title. For a clean seperation between Texera and Amber, we need to move some engine definitions into amber. For now, we keep LogicalPlan, LogicalOperators (DESC) and the majority of Executors are in texera package. Tuple, State, Source/Sink Executors and WorkflowRuntimeStatistics related definitions are moved into Amber.
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title. For a clean seperation between Texera and Amber, we need to move some engine definitions into amber.
For now, we keep LogicalPlan, LogicalOperators (DESC) and the majority of Executors are in texera package.
Tuple, State, Source/Sink Executors and WorkflowRuntimeStatistics related definitions are moved into Amber.