Skip to content

Fix UDF code editor z-index and boundary #2925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sixsage merged 6 commits into from
Oct 27, 2024
Merged

Fix UDF code editor z-index and boundary #2925

sixsage merged 6 commits into from
Oct 27, 2024

Conversation

@sixsage
Copy link
Contributor

@sixsage sixsage commented Oct 11, 2024

Purpose

The issues that this PR addresses:

  1. The docked buttons for left panel and result panel went on top of the udf panel when they are overlapped
  2. The udf panel was able to be dragged outside of the workflow editor workspace, while other panels can't.

Changes

Change the z-index of the udf code editor to a higher index
Change the drag boundary of the udf code editor to the workflow editor workspace.

Demo

Before
udf-z-index-before
After
udf-z-index-after

@sixsage sixsage self-assigned this Oct 11, 2024
@sixsage sixsage changed the title fix z-index and boundary Fix UDF code editor z-index and boundary Oct 11, 2024
@sixsage sixsage added bug fix frontend Changes related to the frontend GUI starter-task labels Oct 11, 2024
@sixsage sixsage marked this pull request as ready for review October 25, 2024 12:04
@sixsage sixsage requested a review from aglinxinyuan October 25, 2024 12:04
aglinxinyuan
aglinxinyuan approved these changes Oct 27, 2024
View reviewed changes
Copy link
Contributor

@aglinxinyuan aglinxinyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sixsage sixsage merged commit 05daeb7 into master Oct 27, 2024
@sixsage sixsage deleted the fix-udf-z-index branch October 27, 2024 05:56
PurelyBlank pushed a commit that referenced this pull request Dec 4, 2024
@sixsage @aglinxinyuan @PurelyBlank
Fix UDF code editor z-index and boundary (#2925)
a0bde12 
## Purpose
The issues that this PR addresses:
1. The docked buttons for left panel and result panel went on top of the
udf panel when they are overlapped
2. The udf panel was able to be dragged outside of the workflow editor
workspace, while other panels can't.
## Changes
Change the z-index of the udf code editor to a higher index
Change the drag boundary of the udf code editor to the workflow editor
workspace.
## Demo
Before

![udf-z-index-before](https://github.com/user-attachments/assets/56a03da3-e631-47ac-9256-35bde8928bb4)
After

![udf-z-index-after](https://github.com/user-attachments/assets/b3e68709-aa90-421f-b4f7-83fe8658c4aa)

Co-authored-by: Xinyuan Lin <xinyual3@uci.edu>
@Yicong-Huang Yicong-Huang removed the bug label Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aglinxinyuan aglinxinyuan aglinxinyuan approved these changes

Assignees

@sixsage sixsage

Labels

fix frontend Changes related to the frontend GUI starter-task

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sixsage @aglinxinyuan @Yicong-Huang