Skip to content

Fix hub workflow detail page not being scrollable #2933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sixsage merged 6 commits into from
Oct 27, 2024
Merged

Fix hub workflow detail page not being scrollable #2933

sixsage merged 6 commits into from
Oct 27, 2024

Conversation

@sixsage
Copy link
Contributor

@sixsage sixsage commented Oct 14, 2024 •
edited
Loading

Purpose

Fix issue where it was not possible to scroll in the hub workflow details page
Fix issue where it was not possible to scroll down to the actual bottom of the quota page

Change

Remove the overflow: hidden in styles.scss
Fix the scrollbar in quota page to properly go down to the bottom of the page

Demo

Quota Page Before
chrome_LDAX8mGEUr
Quota Page After
chrome_eqRK2111SC
Hub Details Page Before
image
Hub Details Page After
chrome_SLHzScl21R

@sixsage sixsage self-assigned this Oct 14, 2024
@sixsage sixsage added bug fix frontend Changes related to the frontend GUI labels Oct 14, 2024
@sixsage sixsage marked this pull request as ready for review October 25, 2024 09:51
@sixsage sixsage requested a review from aglinxinyuan October 25, 2024 09:51
aglinxinyuan
aglinxinyuan approved these changes Oct 27, 2024
View reviewed changes
Copy link
Contributor

@aglinxinyuan aglinxinyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sixsage sixsage merged commit 51ca09b into master Oct 27, 2024
@sixsage sixsage deleted the restore-hub-details-scrollbar branch October 27, 2024 06:25
PurelyBlank pushed a commit that referenced this pull request Dec 4, 2024
@sixsage @aglinxinyuan @PurelyBlank
Fix hub workflow detail page not being scrollable (#2933)
446ea55 
## Purpose
Fix issue where it was not possible to scroll in the hub workflow
details page
Fix issue where it was not possible to scroll down to the actual bottom
of the quota page
## Change
Remove the overflow: hidden in styles.scss
Fix the scrollbar in quota page to properly go down to the bottom of the
page
## Demo
Quota Page Before

![chrome_LDAX8mGEUr](https://github.com/user-attachments/assets/2996d0a9-881a-4e7a-86c2-591124326055)
Quota Page After

![chrome_eqRK2111SC](https://github.com/user-attachments/assets/15022bb3-ecdd-49de-ac91-35ed26dcd532)
Hub Details Page Before

![image](https://github.com/user-attachments/assets/664052f9-fd5c-4e23-b843-858cf40e201b)
Hub Details Page After

![chrome_SLHzScl21R](https://github.com/user-attachments/assets/77060755-ae11-4e0f-8d82-f81362f97f9e)

---------

Co-authored-by: Xinyuan Lin <xinyual3@uci.edu>
@Yicong-Huang Yicong-Huang removed the bug label Oct 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aglinxinyuan aglinxinyuan aglinxinyuan approved these changes

Assignees

@sixsage sixsage

Labels

fix frontend Changes related to the frontend GUI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sixsage @aglinxinyuan @Yicong-Huang