Skip to content

Conversation

@kunwp1
Copy link
Contributor

@kunwp1 kunwp1 commented Oct 15, 2024

This PR enhances the schema handling by retrieving schema information directly from the backend, rather than having the frontend infer it. Accurate schema retrieval is needed due to the binary data.

Previously, binary data was incorrectly treated as a string on the frontend, leading to issues differentiating between string and binary types. For instance, strings containing '0' and '1' were misinterpreted as binary data, resulting in byte representations being displayed in the result panel. This update ensures that the frontend receives the correct schema information, improving data type accuracy and presentation.

By aligning the schema across the backend and frontend, this change resolves existing issues and provides more reliable handling of binary data.

Screenshot 2024-10-15 at 1 41 20 AM

@kunwp1 kunwp1 added the fix label Oct 15, 2024
@kunwp1 kunwp1 requested a review from aglinxinyuan October 15, 2024 08:42
@kunwp1 kunwp1 self-assigned this Oct 15, 2024
Copy link
Contributor

@aglinxinyuan aglinxinyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kunwp1 kunwp1 merged commit e107228 into master Oct 16, 2024
@kunwp1 kunwp1 deleted the chris-schema-from-backend branch October 16, 2024 00:39
PurelyBlank pushed a commit that referenced this pull request Dec 4, 2024
This PR enhances the schema handling by retrieving schema information
directly from the backend, rather than having the frontend infer it.
Accurate schema retrieval is needed due to the binary data.

Previously, binary data was incorrectly treated as a string on the
frontend, leading to issues differentiating between string and binary
types. For instance, strings containing '0' and '1' were misinterpreted
as binary data, resulting in byte representations being displayed in the
result panel. This update ensures that the frontend receives the correct
schema information, improving data type accuracy and presentation.

By aligning the schema across the backend and frontend, this change
resolves existing issues and provides more reliable handling of binary
data.

<img width="1530" alt="Screenshot 2024-10-15 at 1 41 20 AM"
src="https://github.com/user-attachments/assets/d8a13536-34ea-4c2c-89a2-969b9ee1f8fb">

Co-authored-by: Kunwoo Park <kunwoopark@Kunwoos-MacBook-Pro.local>
Co-authored-by: Xinyuan Lin <xinyual3@uci.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants