Fix Port Handling in URL to Avoid Invalid Redirection #2939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
This PR addresses a port handling issue in URL generation to prevent invalid redirection. It introduces logic to check if the port is `-1` (not specified), `80` (default HTTP port), or `443` (default HTTPS port). When the port matches any of these conditions, it is omitted from the URL. Currently, even if the port number is not specified, it still appears in the generated URL, leading to incorrect redirection. This fix ensures that URLs are properly formatted to avoid such issues. [The screenshot of the current issue] <img width="740" alt="Screenshot 2024-10-15 at 11 48 55 AM" src="https://github.com/user-attachments/assets/2da0d8ad-a58f-48bb-8c22-6f128d36021f"> Co-authored-by: Kunwoo Park <kunwoopark@Kunwoos-MacBook-Pro.local> Co-authored-by: Xinyuan Lin <xinyual3@uci.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a port handling issue in URL generation to prevent invalid redirection. It introduces logic to check if the port is
-1(not specified),80(default HTTP port), or443(default HTTPS port). When the port matches any of these conditions, it is omitted from the URL.Currently, even if the port number is not specified, it still appears in the generated URL, leading to incorrect redirection. This fix ensures that URLs are properly formatted to avoid such issues.
[The screenshot of the current issue]
