Encapsulate workflow basic dependencies into a workflow-core package #2942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Can other micro services like |
Contributor
Author
That is the idea. I sent you a POC branch as an example for using workflow-core as dependency. |
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
…2942) This PR adds a new sub-project in sbt called `workflow-core`, under micro-services. It contains a duplicated codebase of workflow core dependencies, including: - `Tuple`, `Attribute`, `Schema`; - `OperatorExecutor`; - `PhysicalOp`, `PhysicalPlan`; - Identities; - and other utility functions. ### Migration plan: After exporting workflow-core as a local dependency, we can build workflow-compiling-service and workflow-execution-service based on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new sub-project in sbt called
workflow-core, under micro-services.It contains a duplicated codebase of workflow core dependencies, including:
Tuple,Attribute,Schema;OperatorExecutor;PhysicalOp,PhysicalPlan;Migration plan:
After exporting workflow-core as a local dependency, we can build workflow-compiling-service and workflow-execution-service based on it.