Fix Dashboard Browser Console Errors #2952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aglinxinyuan
requested changes
Oct 19, 2024
Contributor
aglinxinyuan
left a comment
aglinxinyuan
left a comment
There was a problem hiding this comment.
We don't need to do another forum connection check on the backend. It's possible that after frontend connection error, we simply catch it, such that the error doesn't show on console. Basically we do the same check at frontend.
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
**Propose:** Currently, opening the dashboard triggers some browser errors. Although they do not affect normal functionality, they could potentially lead to other unknown risks. This PR fixes these issues in the dashboard. **Changes:** 1. Using `ChangeDetectorRef` to trigger view updates ensures that the UI stays synchronized with asynchronous data changes. 2. Removed `nz-tooltip` due to conflicts with `nz-icon` causing the `nz0100` error. Additionally, the usage of `nz-icon` overlaps with the `title` attribute. **Demo:** Before:  After: 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propose:
Currently, opening the dashboard triggers some browser errors. Although they do not affect normal functionality, they could potentially lead to other unknown risks. This PR fixes these issues in the dashboard.
Changes:
ChangeDetectorRefto trigger view updates ensures that the UI stays synchronized with asynchronous data changes.nz-tooltipdue to conflicts withnz-iconcausing thenz0100error. Additionally, the usage ofnz-iconoverlaps with thetitleattribute.Demo:
Before:
After:
