Handle empty table in ArrowTupleProvider #2955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shengquan-ni
force-pushed
the
shengquan-fix-arrow-tuple-provider
branch
from
2d9b7d9 to
8d5f5eb
Compare
Contributor
Yicong-Huang
left a comment
Yicong-Huang
left a comment
There was a problem hiding this comment.
It will be good to include a small test case for this purpose. we have test_tuple.py.
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
This PR correctly handles an empty table in ArrowTupleProvider. In such a case, the `next` function should raise `StopIteration` directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR correctly handles an empty table in ArrowTupleProvider. In such a case, the
nextfunction should raiseStopIterationdirectly.