Fix FileDocumentSpec test cases #2957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Yicong-Huang
left a comment
Yicong-Huang
left a comment
There was a problem hiding this comment.
I have some questions regarding the expected functionality.
core/amber/src/test/scala/edu/uci/ics/texera/workflow/common/storage/FileDocumentSpec.scala
Show resolved
Hide resolved
core/amber/src/test/scala/edu/uci/ics/texera/workflow/common/storage/FileDocumentSpec.scala
Show resolved
Hide resolved
Yicong-Huang
approved these changes
Oct 22, 2024
Contributor
Yicong-Huang
left a comment
Yicong-Huang
left a comment
There was a problem hiding this comment.
Good to unblock the CI. Need to revisit for more thorough concurrency tests.
bobbai00
added a commit
that referenced
this pull request
Oct 24, 2024
This PR fixes the issue of `FileDocumentSpec`. Two test cases were written incorrectly. ## The Behavior of the Bug Two test cases occasionally fail in `FileDocumentSpec`. One is for concurrently writing to the same file document, and the other is for concurrently reading from one file document. The failure occurs due to race conditions where multiple threads access the file without proper synchronization. ## How the Fix is Done - **Concurrent Writes**: The fix ensures all threads share the same `FileDocument` instance, allowing `ReentrantReadWriteLock` to properly synchronize write access, preventing race conditions. - **Concurrent Reads**: The fix ensures that multiple threads can safely read from the file after the write operation is complete, using the same instance to coordinate access.
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
This PR fixes the issue of `FileDocumentSpec`. Two test cases were written incorrectly. ## The Behavior of the Bug Two test cases occasionally fail in `FileDocumentSpec`. One is for concurrently writing to the same file document, and the other is for concurrently reading from one file document. The failure occurs due to race conditions where multiple threads access the file without proper synchronization. ## How the Fix is Done - **Concurrent Writes**: The fix ensures all threads share the same `FileDocument` instance, allowing `ReentrantReadWriteLock` to properly synchronize write access, preventing race conditions. - **Concurrent Reads**: The fix ensures that multiple threads can safely read from the file after the write operation is complete, using the same instance to coordinate access.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue of
FileDocumentSpec. Two test cases were written incorrectly.The Behavior of the Bug
Two test cases occasionally fail in
FileDocumentSpec. One is for concurrently writing to the same file document, and the other is for concurrently reading from one file document. The failure occurs due to race conditions where multiple threads access the file without proper synchronization.How the Fix is Done
Concurrent Writes: The fix ensures all threads share the same
FileDocumentinstance, allowingReentrantReadWriteLockto properly synchronize write access, preventing race conditions.Concurrent Reads: The fix ensures that multiple threads can safely read from the file after the write operation is complete, using the same instance to coordinate access.