Add more necessities to workflow-core
#2961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbai00
force-pushed
the
jiadong-put-more-component-to-workflow-core
branch
from
3c0869b to
8a4f1ec
Compare
bobbai00
force-pushed
the
jiadong-put-more-component-to-workflow-core
branch
from
78c2d92 to
729e674
Compare
Yicong-Huang
changed the base branch from
master
to
jiadong-add-dao-micro-services
Yicong-Huang
approved these changes
Oct 24, 2024
core/micro-services/workflow-core/src/main/resources/workflow-core-config.yaml
Outdated
Show resolved
Hide resolved
...ervices/workflow-core/src/main/scala/edu/uci/ics/amber/storage/core/BufferedItemWriter.scala
Outdated
Show resolved
Hide resolved
core/micro-services/workflow-core/src/main/scala/edu/uci/ics/amber/WorkflowCoreConfig.scala
Outdated
Show resolved
Hide resolved
# Conflicts: # core/micro-services/build.sbt # core/micro-services/dao/src/main/scala/edu/uci/ics/texera/dao/SqlServer.scala
This reverts commit 045b7ef.
bobbai00
force-pushed
the
jiadong-put-more-component-to-workflow-core
branch
from
729e674 to
d31a047
Compare
Yicong-Huang
approved these changes
Nov 3, 2024
Contributor
Yicong-Huang
left a comment
Yicong-Huang
left a comment
There was a problem hiding this comment.
LGTM. Left some comments. Make sure all migrated modules reflect the new packaging naming.
core/micro-services/workflow-core/src/main/resources/workflow-core-config.yaml
Outdated
Show resolved
Hide resolved
...es/workflow-core/src/main/scala/edu/uci/ics/amber/core/executor/SourceOperatorExecutor.scala
Outdated
Show resolved
Hide resolved
...ices/workflow-core/src/main/scala/edu/uci/ics/amber/exception/WorkflowRuntimeException.scala
Outdated
Show resolved
Hide resolved
...vices/workflow-core/src/main/scala/edu/uci/ics/amber/storage/model/DatasetFileDocument.scala
Outdated
Show resolved
Hide resolved
...services/workflow-core/src/main/scala/edu/uci/ics/amber/storage/result/OpResultStorage.scala
Outdated
Show resolved
Hide resolved
Yicong-Huang
approved these changes
Nov 3, 2024
core/micro-services/workflow-core/src/main/resources/workflow-core-config.yaml
Outdated
Show resolved
Hide resolved
core/micro-services/workflow-core/src/main/resources/workflow-core-config.yaml
Show resolved
Hide resolved
core/micro-services/workflow-core/src/main/resources/workflow-core-config.yaml
Show resolved
Hide resolved
core/micro-services/workflow-core/src/main/scala/edu/uci/ics/amber/util/ResourceUtils.scala
Outdated
Show resolved
Hide resolved
Contributor
|
@bobbai00 make sure you update Pr description before merging |
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
This PR adds more definition to the `workflow-core` for future components to references. ### What items this PR adds These components include: - under `amber.core` - `WorkflowRuntimeException` - under `amber.core.executer` - `SinkOperatorExecutor` - `SourceOperatorExecutor` - under `amber.core.storage` - `model` => definitions including `BufferedItemWriter`, `VirtualCollection`, `VirtualDocument` and `DatasetFileDocument` - `result` => everything related to store execution results - `util` => utility functions used by storage - `StorageConfig` => config file reader - under `amber.util` - `PathUtils` for resolving some code repo file paths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more definition to the
workflow-corefor future components to references.What items this PR adds
These components include:
amber.coreWorkflowRuntimeExceptionamber.core.executerSinkOperatorExecutorSourceOperatorExecutoramber.core.storagemodel=> definitions includingBufferedItemWriter,VirtualCollection,VirtualDocumentandDatasetFileDocumentresult=> everything related to store execution resultsutil=> utility functions used by storageStorageConfig=> config file readeramber.utilPathUtilsfor resolving some code repo file paths